Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Improve composer heights in some resolutions

This commit is contained in:
Robin Ward 2016-12-29 12:51:36 -05:00
parent a1f0375f1c
commit 61584f6c0c
1 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/assets/javascripts/discourse/lib/safari-hacks.js.es6
View File

@ -6,6 +6,23 @@ function applicable() {
!navigator.userAgent.match(/Trident/g);
}
function calcHeight(composingTopic) {
const winHeight = window.innerHeight;
// Hard code some known iOS resolutions
switch(winHeight) {
case 460: return composingTopic ? 250 : 260;
case 559: return composingTopic ? 325 : 308;
case 627:
case 628: return 360;
}
const ratio = composingTopic ? 0.54 : 0.6;
const min = composingTopic ? 300 : 350;
return Math.max(parseInt(winHeight*ratio), min);
}
let workaroundActive = false;
let composingTopic = false;
@ -86,19 +103,9 @@ function positioningWorkaround($fixedElement) {
fixedElement.style.top = '0px';
let ratio = 0.6;
let min = 350;
composingTopic = $('#reply-control select.category-combobox').length > 0;
composingTopic = false;
if ($('#reply-control select.category-combobox').length > 0) {
composingTopic = true;
// creating a topic, less height
ratio = 0.54;
min = 300;
}
const height = Math.max(parseInt(window.innerHeight*ratio), min);
const height = calcHeight(composingTopic);
fixedElement.style.height = height + "px";