FIX: keep the post_number parameter when redirecting to proper slug

This commit is contained in:
Régis Hanol 2014-08-13 22:12:44 +02:00
parent 9b4c18baf1
commit 6201b82a67
2 changed files with 13 additions and 4 deletions

View File

@ -47,12 +47,12 @@ class TopicsController < ApplicationController
rescue Discourse::NotFound rescue Discourse::NotFound
topic = Topic.find_by(slug: params[:id].downcase) if params[:id] topic = Topic.find_by(slug: params[:id].downcase) if params[:id]
raise Discourse::NotFound unless topic raise Discourse::NotFound unless topic
redirect_to_correct_topic(topic) && return redirect_to_correct_topic(topic, opts[:post_number]) && return
end end
discourse_expires_in 1.minute discourse_expires_in 1.minute
redirect_to_correct_topic(@topic_view.topic) && return if slugs_do_not_match || (!request.xhr? && params[:slug].nil?) redirect_to_correct_topic(@topic_view.topic, opts[:post_number]) && return if slugs_do_not_match || (!request.xhr? && params[:slug].nil?)
track_visit_to_topic track_visit_to_topic
@ -380,8 +380,12 @@ class TopicsController < ApplicationController
params[:slug] && @topic_view.topic.slug != params[:slug] params[:slug] && @topic_view.topic.slug != params[:slug]
end end
def redirect_to_correct_topic(topic) def redirect_to_correct_topic(topic, post_number=nil)
redirect_to "#{topic.relative_url}#{request.format.json? ? ".json" : ""}", status: 301 url = topic.relative_url
url << "/" + post_number if post_number.to_i > 0
url << ".json" if request.format.json?
redirect_to url, status: 301
end end
def track_visit_to_topic def track_visit_to_topic

View File

@ -558,6 +558,11 @@ describe TopicsController do
expect(response).to redirect_to(topic.relative_url) expect(response).to redirect_to(topic.relative_url)
end end
it 'keeps the post_number parameter around when redirecting' do
xhr :get, :show, id: topic.slug, post_number: 42
expect(response).to redirect_to(topic.relative_url + "/42")
end
it 'returns 404 when an invalid slug is given and no id' do it 'returns 404 when an invalid slug is given and no id' do
xhr :get, :show, id: 'nope-nope' xhr :get, :show, id: 'nope-nope'
expect(response.status).to eq(404) expect(response.status).to eq(404)