Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: occasionally getting scrollbar while loading notifications

This commit is contained in:
Sam 2018-03-23 18:19:15 +11:00
parent c294798561
commit 62f09af1c2
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/components/site-header.js.es6
View File

@ -112,7 +112,8 @@ const SiteHeaderComponent = MountWidget.extend(Docking, {
$panel.removeClass('drop-down').removeClass('slide-in').addClass(viewMode); $panel.removeClass('drop-down').removeClass('slide-in').addClass(viewMode);
const $panelBody = $('.panel-body', $panel); const $panelBody = $('.panel-body', $panel);
let contentHeight = parseInt($('.panel-body-contents', $panel).height()); // 2 pixel fudge allows for firefox subpixel sizing stuff causing scrollbar
let contentHeight = parseInt($('.panel-body-contents', $panel).height()) + 2;
// We use a mutationObserver to check for style changes, so it's important // We use a mutationObserver to check for style changes, so it's important
// we don't set it if it doesn't change. Same goes for the $panelBody! // we don't set it if it doesn't change. Same goes for the $panelBody!

3
app/assets/stylesheets/common/base/menu-panel.scss
View File

@ -223,6 +223,9 @@
.user-menu { .user-menu {
.notifications { .notifications {
width: 100%;
display: table;
h3 { h3 {
padding: 0 0.4em; padding: 0 0.4em;
font-weight: bold; font-weight: bold;