PERF: Prefer joins over IN () queries.

This commit is contained in:
Guo Xiang Tan 2019-05-29 08:51:30 +08:00
parent 76569b2018
commit 63292cecd9

View File

@ -23,9 +23,8 @@ class UserSearch
users = users.where(staged: false) unless @include_staged_users users = users.where(staged: false) unless @include_staged_users
if @group if @group
users = users.where('users.id IN ( users = users.joins("INNER JOIN group_users ON group_users.user_id = users.id")
SELECT user_id FROM group_users WHERE group_id = ? .where("group_users.group_id = ?", @group.id)
)', @group.id)
end end
unless @searching_user && @searching_user.staff? unless @searching_user && @searching_user.staff?