DEV: Debug AR connection pool queue on CI (#25828)
Why this change? On CI, we have been seeing flaky system tests because ActiveRecord is unable to checkout a connection. This patch is meant to help us debug which thread is not returning the connection to the queue. Example of timeout issue: https://github.com/discourse/discourse/actions/runs/8012541636/job/21888013082
This commit is contained in:
parent
a72dc2f420
commit
6437f27f90
|
@ -254,6 +254,7 @@ jobs:
|
|||
if: matrix.build_type == 'system' && matrix.target == 'chat'
|
||||
env:
|
||||
CHECKOUT_TIMEOUT: 10
|
||||
DEBUG_AR_CONNECTION_QUEUE: 1
|
||||
run: LOAD_PLUGINS=1 RAILS_ENABLE_TEST_LOG=1 RAILS_TEST_LOG_LEVEL=error PARALLEL_TEST_PROCESSORS=4 bin/turbo_rspec --use-runtime-info --profile=50 --verbose --format documentation plugins/chat/spec/system
|
||||
timeout-minutes: 30
|
||||
|
||||
|
|
|
@ -0,0 +1,40 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
if ENV["DEBUG_AR_CONNECTION_QUEUE"] == "1"
|
||||
module QueuePatch
|
||||
# Add +element+ to the queue. Never blocks.
|
||||
def add(element)
|
||||
puts "::group::##{Process.pid} Adding element to the queue"
|
||||
puts Thread.current.backtrace.first(30).join("\n")
|
||||
puts "::endgroup::"
|
||||
super
|
||||
end
|
||||
|
||||
# If +element+ is in the queue, remove and return it, or +nil+.
|
||||
def delete(element)
|
||||
puts "::group::##{Process.pid} Delete element from the queue"
|
||||
puts Thread.current.backtrace.first(30).join("\n")
|
||||
puts "::endgroup::"
|
||||
super
|
||||
end
|
||||
|
||||
# Remove all elements from the queue.
|
||||
def clear
|
||||
puts "::group::##{Process.pid} Clear all elements from the queue"
|
||||
puts Thread.current.backtrace.first(30).join("\n")
|
||||
puts "::endgroup::"
|
||||
super
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def remove
|
||||
puts "::group::##{Process.pid} Removing element from the queue"
|
||||
puts Thread.current.backtrace.first(30).join("\n")
|
||||
puts "::endgroup::"
|
||||
super
|
||||
end
|
||||
end
|
||||
|
||||
ActiveRecord::ConnectionAdapters::ConnectionPool::Queue.prepend(QueuePatch)
|
||||
end
|
Loading…
Reference in New Issue