From 64a45b0980f89d4356f272dbf606db193a436bce Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Tue, 17 Apr 2018 15:56:55 +0800 Subject: [PATCH] FIX: Missing `Group#bio_raw` attribute for group owners. https://meta.discourse.org/t/group-description-does-not-load-in-editor-for-owners-who-are-not-staff/85345 --- app/serializers/basic_group_serializer.rb | 2 +- .../basic_group_serializer_spec.rb | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/app/serializers/basic_group_serializer.rb b/app/serializers/basic_group_serializer.rb index 095324ca330..6283dfa12e6 100644 --- a/app/serializers/basic_group_serializer.rb +++ b/app/serializers/basic_group_serializer.rb @@ -47,7 +47,7 @@ class BasicGroupSerializer < ApplicationSerializer end def include_bio_raw? - staff? + staff? || is_group_owner end def include_is_group_user? diff --git a/spec/serializers/basic_group_serializer_spec.rb b/spec/serializers/basic_group_serializer_spec.rb index 712f06fa7f3..4d1801ff924 100644 --- a/spec/serializers/basic_group_serializer_spec.rb +++ b/spec/serializers/basic_group_serializer_spec.rb @@ -1,6 +1,8 @@ require 'rails_helper' describe BasicGroupSerializer do + let(:guardian) { Guardian.new } + let(:group) { Fabricate(:group) } subject { described_class.new(group, scope: Guardian.new, root: false) } describe '#display_name' do @@ -20,4 +22,22 @@ describe BasicGroupSerializer do end end end + + describe '#bio_raw' do + let(:group) { Fabricate(:group, bio_raw: 'testing') } + + let(:user) do + user = Fabricate(:user) + group.add_owner(user) + user + end + + let(:guardian) { Guardian.new(user) } + + describe 'group owner' do + it 'should include bio_raw' do + expect(subject.bio_raw).to eq('testing') + end + end + end end