Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: Reduce the number of queries when voting.

This commit is contained in:
Guo Xiang Tan 2016-07-29 14:02:48 +08:00
parent fc7ebc342c
commit 6538363c18
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
plugins/poll/plugin.rb
View File

@ -32,8 +32,9 @@ after_initialize do
class DiscoursePoll::Poll class DiscoursePoll::Poll
class << self class << self
def vote(post_id, poll_name, options, user_id) def vote(post_id, poll_name, options, user)
DistributedMutex.synchronize("#{PLUGIN_NAME}-#{post_id}") do DistributedMutex.synchronize("#{PLUGIN_NAME}-#{post_id}") do
user_id = user.id
post = Post.find_by(id: post_id) post = Post.find_by(id: post_id)
# post must not be deleted # post must not be deleted
@ -65,11 +66,10 @@ after_initialize do
poll["voters"] = poll["anonymous_voters"] || 0 poll["voters"] = poll["anonymous_voters"] || 0
all_options = Hash.new(0) all_options = Hash.new(0)
post.custom_fields[DiscoursePoll::VOTES_CUSTOM_FIELD] ||= {} polls["#{user_id}"] ||= {}
post.custom_fields[DiscoursePoll::VOTES_CUSTOM_FIELD]["#{user_id}"] ||= {} polls["#{user_id}"][poll_name] = options
post.custom_fields[DiscoursePoll::VOTES_CUSTOM_FIELD]["#{user_id}"][poll_name] = options
post.custom_fields[DiscoursePoll::VOTES_CUSTOM_FIELD].each do |_, user_votes| polls.each do |_, user_votes|
next unless votes = user_votes[poll_name] next unless votes = user_votes[poll_name]
votes.each { |option| all_options[option] += 1 } votes.each { |option| all_options[option] += 1 }
poll["voters"] += 1 if (available_options & votes.to_set).size > 0 poll["voters"] += 1 if (available_options & votes.to_set).size > 0
@ -96,9 +96,7 @@ after_initialize do
payload = { post_id: post_id, polls: polls } payload = { post_id: post_id, polls: polls }
if public_poll if public_poll
payload.merge!( payload.merge!(user: UserNameSerializer.new(user).serializable_hash)
user: UserNameSerializer.new(User.find(user_id)).serializable_hash
)
end end
MessageBus.publish("/polls/#{post.topic_id}", payload) MessageBus.publish("/polls/#{post.topic_id}", payload)
@ -188,10 +186,9 @@ after_initialize do
post_id = params.require(:post_id) post_id = params.require(:post_id)
poll_name = params.require(:poll_name) poll_name = params.require(:poll_name)
options = params.require(:options) options = params.require(:options)
user_id = current_user.id
begin begin
poll, options = DiscoursePoll::Poll.vote(post_id, poll_name, options, user_id) poll, options = DiscoursePoll::Poll.vote(post_id, poll_name, options, current_user)
render json: { poll: poll, vote: options } render json: { poll: poll, vote: options }
rescue StandardError => e rescue StandardError => e
render_json_error e.message render_json_error e.message