Merge pull request #3562 from riking/no-index

Add noindex directive on unlisted topics

app/controllers/topics_controller.rb

@@ -77,6 +77,10 @@ class TopicsController < ApplicationController
       @topic_view.draft = Draft.get(current_user, @topic_view.draft_key, @topic_view.draft_sequence)
     end
 
+    unless @topic_view.topic.visible
+      response.headers['X-Robots-Tag'] = 'noindex'
+    end
+
     perform_show_response
 
     canonical_url UrlHelper.absolute_without_cdn("#{Discourse.base_uri}#{@topic_view.canonical_path}")

spec/controllers/topics_controller_spec.rb

@@ -1018,4 +1018,19 @@ describe TopicsController do
       expect(json["banner_count"]).to eq(1)
     end
   end
+
+  describe "x-robots-tag" do
+    it "is included for unlisted topics" do
+      topic = Fabricate(:topic, visible: false)
+      get :show, topic_id: topic.id, slug: topic.slug
+
+      expect(response.headers['X-Robots-Tag']).to eq('noindex')
+    end
+    it "is not included for normal topics" do
+      topic = Fabricate(:topic, visible: true)
+      get :show, topic_id: topic.id, slug: topic.slug
+
+      expect(response.headers['X-Robots-Tag']).to eq(nil)
+    end
+  end
 end