From 664186a2a43c143ab65cae9422e8b180579d3d9c Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Mon, 13 Aug 2018 14:48:15 +0800 Subject: [PATCH] DEV: Remove stub to make test more reliable. --- spec/models/user_avatar_spec.rb | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/spec/models/user_avatar_spec.rb b/spec/models/user_avatar_spec.rb index 7bc27537a2e..f67cd4896cc 100644 --- a/spec/models/user_avatar_spec.rb +++ b/spec/models/user_avatar_spec.rb @@ -86,8 +86,14 @@ describe UserAvatar do user = Fabricate(:user, uploaded_avatar_id: 1) user.user_avatar.update_columns(gravatar_upload_id: 1) - FileHelper.stubs(:download).returns(file_from_fixtures("logo.png")) - UserAvatar.import_url_for_user("logo.png", user, override_gravatar: false) + stub_request(:get, "http://thisfakesomething.something.com/") + .to_return(status: 200, body: file_from_fixtures("logo.png"), headers: {}) + + url = "http://thisfakesomething.something.com/" + + expect do + UserAvatar.import_url_for_user(url, user, override_gravatar: false) + end.to change { Upload.count }.by(1) user.reload expect(user.uploaded_avatar_id).to eq(1) @@ -101,7 +107,9 @@ describe UserAvatar do url = "http://thisfakesomething.something.com/" - UserAvatar.import_url_for_user(url, user) + expect do + UserAvatar.import_url_for_user(url, user) + end.to_not change { Upload.count } user.reload