From 6774c600a4dfb18bc2cdb0b58e69a6e3c27687bd Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Tue, 10 Aug 2021 14:30:22 +1000 Subject: [PATCH] DEV: Fix uploads controller flaky presigned put spec (#13985) Was missing RateLimiter.clear_all!, leading to 403 errors --- spec/requests/uploads_controller_spec.rb | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/spec/requests/uploads_controller_spec.rb b/spec/requests/uploads_controller_spec.rb index ae78d21329b..c14e3f31638 100644 --- a/spec/requests/uploads_controller_spec.rb +++ b/spec/requests/uploads_controller_spec.rb @@ -706,12 +706,9 @@ describe UploadsController do end describe "#generate_presigned_put" do - before do - sign_in(user) - end - context "when the store is external" do before do + sign_in(user) SiteSetting.enable_direct_s3_uploads = true setup_s3 end @@ -761,6 +758,8 @@ describe UploadsController do it "rate limits" do RateLimiter.enable + RateLimiter.clear_all! + stub_const(UploadsController, "PRESIGNED_PUT_RATE_LIMIT_PER_MINUTE", 1) do post "/uploads/generate-presigned-put.json", params: { file_name: "test.png", type: "card_background" } post "/uploads/generate-presigned-put.json", params: { file_name: "test.png", type: "card_background" } @@ -770,6 +769,10 @@ describe UploadsController do end context "when the store is not external" do + before do + sign_in(user) + end + it "returns 404" do post "/uploads/generate-presigned-put.json", params: { file_name: "test.png", type: "card_background" } expect(response.status).to eq(404)