From 69dbc207ab3939b22e7984546dd8f0247da003c2 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Wed, 6 Apr 2022 18:29:39 +0200 Subject: [PATCH] DEV: Improve `plugin:versions` task (#16391) 1. Sort plugins by name 2. Include plugins that are a symbolic link to a submodule repo (in those cases `.git` isn't a directory but a file that looks like e.g. `gitdir: ../../.git/modules/plugins/name-here`) --- lib/tasks/plugin.rake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/tasks/plugin.rake b/lib/tasks/plugin.rake index ea97745b166..451c7e23097 100644 --- a/lib/tasks/plugin.rake +++ b/lib/tasks/plugin.rake @@ -241,8 +241,9 @@ task 'plugin:versions' do |t, args| [plugin, "plugins/#{plugin}", "plugins/#{plugin}/.git"] } .select { |plugin, plugin_dir, plugin_git_dir| - File.directory?(plugin_dir) && File.directory?(plugin_git_dir) + File.directory?(plugin_dir) && File.exist?(plugin_git_dir) } + .sort_by { |plugin, _, _| plugin } .map { |plugin, _, plugin_git_dir| version = `git --git-dir \"#{plugin_git_dir}\" rev-parse HEAD` abort("unable to get #{plugin} version") unless version