Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: Stop serializing user in `ChatChannelSerializer#current_user_membership` (#19527) 

The client already has all the information about the current user so
there is no need for us to be serializing the current `User` object each
time per channel that is preloaded.

In production, profiling shows that this unneeded serializing
adds a roughly 5% overhead to a request.
This commit is contained in:
Alan Guo Xiang Tan 2022-12-22 05:30:06 +08:00 committed by GitHub
parent aa1e8790e5
commit 6bcf558bae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/app/serializers/base_chat_channel_membership_serializer.rb Normal file
View File

@ -0,0 +1,12 @@
# frozen_string_literal: true
class BaseChatChannelMembershipSerializer < ApplicationSerializer
attributes :following,
:muted,
:desktop_notification_level,
:mobile_notification_level,
:chat_channel_id,
:last_read_message_id,
:unread_count,
:unread_mentions
end

3
plugins/chat/app/serializers/chat_channel_serializer.rb
View File

@ -94,7 +94,8 @@ class ChatChannelSerializer < ApplicationSerializer
def current_user_membership def current_user_membership
@current_user_membership.chat_channel = object @current_user_membership.chat_channel = object
UserChatChannelMembershipSerializer.new(
BaseChatChannelMembershipSerializer.new(
@current_user_membership, @current_user_membership,
scope: scope, scope: scope,
root: false, root: false,

11
plugins/chat/app/serializers/user_chat_channel_membership_serializer.rb
View File

@ -1,15 +1,6 @@
# frozen_string_literal: true # frozen_string_literal: true
class UserChatChannelMembershipSerializer < ApplicationSerializer class UserChatChannelMembershipSerializer < BaseChatChannelMembershipSerializer
attributes :following,
:muted,
:desktop_notification_level,
:mobile_notification_level,
:chat_channel_id,
:last_read_message_id,
:unread_count,
:unread_mentions
has_one :user, serializer: BasicUserSerializer, embed: :objects has_one :user, serializer: BasicUserSerializer, embed: :objects
def user def user

1
plugins/chat/plugin.rb
View File

@ -145,6 +145,7 @@ after_initialize do
load File.expand_path("../app/serializers/structured_channel_serializer.rb", __FILE__) load File.expand_path("../app/serializers/structured_channel_serializer.rb", __FILE__)
load File.expand_path("../app/serializers/chat_webhook_event_serializer.rb", __FILE__) load File.expand_path("../app/serializers/chat_webhook_event_serializer.rb", __FILE__)
load File.expand_path("../app/serializers/chat_in_reply_to_serializer.rb", __FILE__) load File.expand_path("../app/serializers/chat_in_reply_to_serializer.rb", __FILE__)
load File.expand_path("../app/serializers/base_chat_channel_membership_serializer.rb", __FILE__)
load File.expand_path("../app/serializers/user_chat_channel_membership_serializer.rb", __FILE__) load File.expand_path("../app/serializers/user_chat_channel_membership_serializer.rb", __FILE__)
load File.expand_path("../app/serializers/chat_message_serializer.rb", __FILE__) load File.expand_path("../app/serializers/chat_message_serializer.rb", __FILE__)
load File.expand_path("../app/serializers/chat_channel_serializer.rb", __FILE__) load File.expand_path("../app/serializers/chat_channel_serializer.rb", __FILE__)