The last of the callback style AJAX have been converted to promises.

app/assets/javascripts/discourse/components/message_bus.js

@@ -73,7 +73,7 @@ Discourse.MessageBus = (function() {
           data[c.channel] = c.last_id === void 0 ? -1 : c.last_id;
         });
         gotData = false;
-        _this.longPoll = Discourse.ajax(Discourse.getURL("/message-bus/") + clientId + "/poll?" + (!shouldLongPoll() || !_this.enableLongPolling ? "dlp=t" : ""), {
+        _this.longPoll = $.ajax(Discourse.getURL("/message-bus/") + clientId + "/poll?" + (!shouldLongPoll() || !_this.enableLongPolling ? "dlp=t" : ""), {
           data: data,
           cache: false,
           dataType: 'json',

app/assets/javascripts/discourse/models/category.js

@@ -35,7 +35,7 @@ Discourse.Category = Discourse.Model.extend({
       url = Discourse.getURL("/categories/") + (this.get('id'));
     }
 
-    return this.ajax(url, {
+    return Discourse.ajax(url, {
       data: {
         name: this.get('name'),
         color: this.get('color'),

app/assets/javascripts/discourse/models/model.js

@@ -9,21 +9,6 @@
 **/
 Discourse.Model = Ember.Object.extend(Discourse.Presence, {
 
-  /**
-    Our own AJAX handler that handles erronous responses
-
-    @method ajax
-    @param {String} url The url to contact
-    @param {Object} args The arguments to pass to $.ajax
-  **/
-  ajax: function(url, args) {
-    var oldError = args.error;
-    args.error = function(xhr) {
-      return oldError($.parseJSON(xhr.responseText).errors);
-    };
-    return Discourse.ajax(url, args);
-  },
-
   /**
     Update our object from another object
 

app/assets/javascripts/discourse/models/post.js

@@ -83,22 +83,23 @@ Discourse.Post = Discourse.Model.extend({
     return Em.String.i18n('bookmarks.not_bookmarked');
   }).property('read', 'topic.last_read_post_number', 'bookmarked'),
 
-  bookmarkedChanged: (function() {
+  bookmarkedChanged: function() {
-    var _this = this;
+    var post = this;
-    return Discourse.ajax({
+    Discourse.ajax({
       url: Discourse.getURL("/posts/") + (this.get('id')) + "/bookmark",
       type: 'PUT',
       data: {
         bookmarked: this.get('bookmarked') ? true : false
-      },
+      }
-      error: function(error) {
+    }).fail(function (error) {
-        var errors;
+      if (error && error.responseText) {
-        errors = $.parseJSON(error.responseText).errors;
+        bootbox.alert($.parseJSON(error.responseText).errors[0]);
-        bootbox.alert(errors[0]);
+      } else {
-        return _this.toggleProperty('bookmarked');
+        bootbox.alert(Em.String.i18n('generic_error'));
       }
     });
-  }).observes('bookmarked'),
+
+  }.observes('bookmarked'),
 
   internalLinks: (function() {
     if (this.blank('link_counts')) return null;

app/assets/javascripts/discourse/models/topic.js

@@ -160,11 +160,14 @@ Discourse.Topic = Discourse.Model.extend({
     return Discourse.ajax({
       url: "" + (this.get('url')) + "/star",
       type: 'PUT',
-      data: { starred: topic.get('starred') ? true : false },
+      data: { starred: topic.get('starred') ? true : false }
-      error: function(error) {
+    }).fail(function (error) {
       topic.toggleProperty('starred');
-        var errors = $.parseJSON(error.responseText).errors;
+
-        return bootbox.alert(errors[0]);
+      if (error && error.responseText) {
+        bootbox.alert($.parseJSON(error.responseText).errors);
+      } else {
+        bootbox.alert(Em.String.i18n('generic_error'));
       }
     });
   },
@@ -349,11 +352,10 @@ Discourse.Topic = Discourse.Model.extend({
     topic.set('pinned', false);
 
     Discourse.ajax(Discourse.getURL("/t/") + this.get('id') + "/clear-pin", {
-      type: 'PUT',
+      type: 'PUT'
-      error: function() {
+    }).fail(function() {
       // On error, put the pin back
       topic.set('pinned', true);
-      }
     });
   },
 

app/assets/javascripts/discourse/models/user.js

@@ -159,11 +159,9 @@ Discourse.User = Discourse.Model.extend({
                                'new_topic_duration_minutes',
                                'external_links_in_new_tab',
                                'enable_quoting'),
-      type: 'PUT',
+      type: 'PUT'
-      success: function(data) {
+    }).then(function(data) {
       user.set('bio_excerpt',data.user.bio_excerpt);
-      }
-    }).then(function() {
       Discourse.set('currentUser.enable_quoting', user.get('enable_quoting'));
       Discourse.set('currentUser.external_links_in_new_tab', user.get('external_links_in_new_tab'));
     });

sublime-project

@@ -3,7 +3,7 @@
   [
     {
       "path": "app",
-      "folder_exclude_patterns": ["external", "external_production", "images", "imported", "fonts", "defer"],
+      "folder_exclude_patterns": ["external", "external_development", "external_production", "images", "imported", "fonts", "defer"],
       "file_exclude_patterns": ["i18n.js"]
     },
     { "path": "config" },