Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: max 1 day of view time per topic 

we were overflowing ints in some conditions and flooding error logs
This commit is contained in:
Sam 2014-09-12 16:59:25 +10:00
parent 135b1f63e8
commit 6d5e6b3e33
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/topic_user.rb
View File

@ -156,11 +156,13 @@ class TopicUser < ActiveRecord::Base
# seen_post_count represents the highest_post_number of the topic when # seen_post_count represents the highest_post_number of the topic when
# the user visited it. It may be out of alignment with last_read, meaning # the user visited it. It may be out of alignment with last_read, meaning
# ... user visited the topic but did not read the posts # ... user visited the topic but did not read the posts
#
# 86400000 = 1 day
rows = exec_sql("UPDATE topic_users rows = exec_sql("UPDATE topic_users
SET SET
last_read_post_number = greatest(:post_number, tu.last_read_post_number), last_read_post_number = GREATEST(:post_number, tu.last_read_post_number),
seen_post_count = t.highest_post_number, seen_post_count = t.highest_post_number,
total_msecs_viewed = tu.total_msecs_viewed + :msecs, total_msecs_viewed = LEAST(tu.total_msecs_viewed + :msecs,86400000),
notification_level = notification_level =
case when tu.notifications_reason_id is null and (tu.total_msecs_viewed + :msecs) > case when tu.notifications_reason_id is null and (tu.total_msecs_viewed + :msecs) >
coalesce(u.auto_track_topics_after_msecs,:threshold) and coalesce(u.auto_track_topics_after_msecs,:threshold) and