Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-07 20:08:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Count views on published pages (#17878)

Browse Source 
* FEATURE: Count views on published pages

* Removed trailing whitespaces

* Fixed the test
This commit is contained in:
Frank 2022-08-19 00:11:19 +08:00 committed by GitHub
parent c63580b226
commit 6e682cc7c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/published_pages_controller.rb
View File

@ -35,6 +35,8 @@ class PublishedPagesController < ApplicationController
@site_url = Discourse.base_url @site_url = Discourse.base_url
@border_color = "#" + ColorScheme.base_colors["tertiary"] @border_color = "#" + ColorScheme.base_colors["tertiary"]
TopicViewItem.add(pp.topic.id, request.remote_ip, current_user ? current_user.id : nil)
@body_classes = Set.new([ @body_classes = Set.new([
'published-page', 'published-page',
params[:slug], params[:slug],

9
spec/requests/published_pages_controller_spec.rb
View File

@ -4,6 +4,7 @@ RSpec.describe PublishedPagesController do
fab!(:published_page) { Fabricate(:published_page) } fab!(:published_page) { Fabricate(:published_page) }
fab!(:admin) { Fabricate(:admin) } fab!(:admin) { Fabricate(:admin) }
fab!(:user) { Fabricate(:user) } fab!(:user) { Fabricate(:user) }
fab!(:user2) { Fabricate(:user) }
context "when enabled" do context "when enabled" do
before do before do
@ -39,6 +40,14 @@ RSpec.describe PublishedPagesController do
end end
describe "#show" do describe "#show" do
it 'records a view' do
sign_in(user2)
expect do
get published_page.path
end.to change(TopicViewItem, :count).by(1)
end
it "returns 404 for a missing article" do it "returns 404 for a missing article" do
get "/pub/no-article-here-no-thx" get "/pub/no-article-here-no-thx"
expect(response.status).to eq(404) expect(response.status).to eq(404)