DEV: Use `has_no_css?` instead of `!has_css?` (#21874)

If we're asserting that something is missing, we want to use
`has_no_css?` instead of `!has_css?` since `has_css?` will wait the full
capybara default wait time before return if the selector is not present.
This commit is contained in:
Alan Guo Xiang Tan 2023-06-01 11:41:43 +09:00 committed by GitHub
parent ba251dec6b
commit 6fec9628a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 7 deletions

View File

@ -18,14 +18,11 @@ module PageObjects
end
def has_drawer?(channel_id: nil, expanded: true)
selector = ".chat-drawer"
selector += ".is-expanded" if expanded
selector += "[data-chat-channel-id=\"#{channel_id}\"]" if channel_id
has_css?(selector)
drawer?(expectation: true, channel_id: channel_id, expanded: expanded)
end
def has_no_drawer?(**args)
!has_drawer?(**args)
def has_no_drawer?(channel_id: nil, expanded: true)
drawer?(expectation: false, channel_id: channel_id, expanded: expanded)
end
def visit_channel(channel, message_id: nil)
@ -85,6 +82,15 @@ module PageObjects
def has_no_new_channel_button?
has_no_css?(NEW_CHANNEL_BUTTON_SELECTOR)
end
private
def drawer?(expectation:, channel_id: nil, expanded: true)
selector = ".chat-drawer"
selector += ".is-expanded" if expanded
selector += "[data-chat-channel-id=\"#{channel_id}\"]" if channel_id
expectation ? has_css?(selector) : has_no_css?(selector)
end
end
end
end

View File

@ -12,7 +12,7 @@ module PageObjects
end
def has_no_open_thread?
!has_css?(".chat-side-panel .chat-thread")
has_no_css?(".chat-side-panel .chat-thread")
end
def has_open_thread_list?