From 70cdb42173e10acdd23e42ad3dd3b13215c6c1bd Mon Sep 17 00:00:00 2001 From: Gerhard Schlager Date: Tue, 15 Jan 2019 16:13:06 +0100 Subject: [PATCH] FIX: Tooltip for unlisted topics wasn't shown in topic list The locale key had to be renamed, because this key is also used as CSS class. The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect. --- app/assets/javascripts/discourse/components/topic-status.js.es6 | 2 +- app/assets/javascripts/discourse/raw-views/topic-status.js.es6 | 2 +- app/assets/javascripts/discourse/widgets/topic-status.js.es6 | 2 +- config/locales/client.en.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/components/topic-status.js.es6 b/app/assets/javascripts/discourse/components/topic-status.js.es6 index 2ab678f9d21..1929cf15e01 100644 --- a/app/assets/javascripts/discourse/components/topic-status.js.es6 +++ b/app/assets/javascripts/discourse/components/topic-status.js.es6 @@ -65,7 +65,7 @@ export default Ember.Component.extend( "unpinned", this.get("canAct") ); - renderIconIf("topic.invisible", "eye-slash", "invisible"); + renderIconIf("topic.invisible", "far-eye-slash", "unlisted"); } }) ); diff --git a/app/assets/javascripts/discourse/raw-views/topic-status.js.es6 b/app/assets/javascripts/discourse/raw-views/topic-status.js.es6 index 6fd967b9177..6aeee4e5cda 100644 --- a/app/assets/javascripts/discourse/raw-views/topic-status.js.es6 +++ b/app/assets/javascripts/discourse/raw-views/topic-status.js.es6 @@ -53,7 +53,7 @@ export default Ember.Object.extend({ } if (topic.get("invisible")) { - results.push({ icon: "eye-slash" }); + results.push({ icon: "far-eye-slash", key: "unlisted" }); } results.forEach(result => { diff --git a/app/assets/javascripts/discourse/widgets/topic-status.js.es6 b/app/assets/javascripts/discourse/widgets/topic-status.js.es6 index ff03d826573..2650563e1ed 100644 --- a/app/assets/javascripts/discourse/widgets/topic-status.js.es6 +++ b/app/assets/javascripts/discourse/widgets/topic-status.js.es6 @@ -39,7 +39,7 @@ export default createWidget("topic-status", { renderIconIf("pinned", "thumbtack", "pinned"); renderIconIf("unpinned", "thumbtack", "unpinned"); - renderIconIf("invisible", "eye-slash", "invisible"); + renderIconIf("invisible", "far-eye-slash", "unlisted"); return result; } diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index a0ab970a488..12d29ad8515 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -2512,7 +2512,7 @@ en: pinned: title: "Pinned" help: "This topic is pinned for you; it will display at the top of its category" - invisible: + unlisted: help: "This topic is unlisted; it will not be displayed in topic lists, and can only be accessed via a direct link" posts: "Posts"