Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: topic embed blank tags or passed with nil do not blank out existing topic tags (#27699) 

When a topic embed is run with either no tags argument or a nil tag argument
this should not affect any existing tags.

Only update topic tags when tags argument is explicitly empty.
This commit is contained in:
Jeff Wong 2024-07-03 14:50:59 -07:00 committed by GitHub
parent 3a6762d2be
commit 70fc39211b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/topic_embed.rb
View File

@ -124,7 +124,7 @@ class TopicEmbed < ActiveRecord::Base
existing_tag_names = post.topic.tags.pluck(:name).sort
incoming_tag_names = Array(tags).map { |tag| tag.respond_to?(:name) ? tag.name : tag }.sort
tags_changed = existing_tag_names != incoming_tag_names
tags_changed = !tags.nil? && existing_tag_names != incoming_tag_names
if (content_sha1 != embed.content_sha1) || (title && title != post&.topic&.title) ||
tags_changed

12
spec/models/topic_embed_spec.rb
View File

@ -371,6 +371,18 @@ RSpec.describe TopicEmbed do
imported_page = TopicEmbed.import(user, url, title, contents, tags: tags)
expect(imported_page.topic.tags).to match_array([tag1, tag2])
end
it "does not update tags if tags are nil or unspecified" do
imported_page = TopicEmbed.import(user, url, title, contents)
expect(imported_page.topic.tags).to match_array([tag1])
imported_page = TopicEmbed.import(user, url, title, contents, tags: nil)
expect(imported_page.topic.tags).to match_array([tag1])
end
it "does update tags if tags are empty" do
imported_page = TopicEmbed.import(user, url, title, contents, tags: [])
expect(imported_page.topic.tags).to match_array([])
end
end
context "with specified user and tags" do