Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix flaky admin confirmation spec (#27784) 

Waiting for the dialog to close was not enough,
need to wait for the overridden indicator to
show on the site setting.
This commit is contained in:
Martin Brennan 2024-07-09 12:05:31 +10:00 committed by GitHub
parent c0ac15575f
commit 7111d5e4bf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
spec/system/admin_site_setting_requires_confirmation_spec.rb
View File

@ -26,6 +26,7 @@ describe "Admin Site Setting Requires Confirmation", type: :system do
) )
dialog.click_yes dialog.click_yes
expect(dialog).to be_closed expect(dialog).to be_closed
expect(settings_page).to have_overridden_setting("min_password_length")
expect(SiteSetting.min_password_length).to eq(12) expect(SiteSetting.min_password_length).to eq(12)
end end

10
spec/system/page_objects/pages/admin_site_settings.rb
View File

@ -22,8 +22,10 @@ module PageObjects
self self
end end
def find_setting(setting_name) def find_setting(setting_name, overridden: false)
find(".admin-detail .row.setting[data-setting='#{setting_name}']") find(
".admin-detail .row.setting[data-setting='#{setting_name}']#{overridden ? ".overridden" : ""}",
)
end end
def toggle_setting(setting_name, text = "") def toggle_setting(setting_name, text = "")
@ -49,6 +51,10 @@ module PageObjects
setting_element.find(".setting-controls button.ok").click setting_element.find(".setting-controls button.ok").click
end end
def has_overridden_setting?(setting_name)
find_setting(setting_name, overridden: true)
end
def values_in_list(setting_name) def values_in_list(setting_name)
vals = [] vals = []
setting = find(".admin-detail .row.setting[data-setting='#{setting_name}']") setting = find(".admin-detail .row.setting[data-setting='#{setting_name}']")