Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: Correctly memoize baseUri value in javascript app (#9986) 

An empty string is a falsey value in javascript, so we were looking for the meta tag every time getURL was called, which took approximately 1.5ms every time.
This commit is contained in:
David Taylor 2020-06-05 13:36:48 +01:00 committed by GitHub
parent 6c7e9d3255
commit 731263b81c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse-common/addon/lib/get-url.js
View File

@ -4,7 +4,7 @@ let S3BaseUrl, S3CDN;
export default function getURL(url) { export default function getURL(url) {
if (!url) return url; if (!url) return url;
if (!baseUri) { if (baseUri === undefined) {
baseUri = $('meta[name="discourse-base-uri"]').attr("content") || ""; baseUri = $('meta[name="discourse-base-uri"]').attr("content") || "";
} }