Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-06 03:18:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Use click once for video place holder (#24141)

Browse Source 
Rather than removing the event listener just use `{once: true}`.

docs: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#once

meta: https://meta.discourse.org/t/283596
This commit is contained in:
Blake Erickson 2023-10-27 08:55:19 -06:00 committed by GitHub
parent 1c70a14d7c
commit 73589fa475
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/app/instance-initializers/video-placeholder.js
View File

@ -13,7 +13,6 @@ export default {
const overlay = wrapper.querySelector(".video-placeholder-overlay");
parentDiv.style.cursor = "";
parentDiv.removeEventListener("click", handleVideoPlaceholderClick);
overlay.innerHTML = spinnerHTML;
const videoHTML = `
@ -83,7 +82,7 @@ export default {
container.addEventListener(
"click",
handleVideoPlaceholderClick.bind(null, helper),
false
{ once: true }
);
overlay.innerHTML = `${iconHTML("play")}`;
wrapper.appendChild(overlay);