Merge pull request #2871 from mamhoff/autocomplete-again

Fix buggy autocomplete behaviour for non-US keyboards

app/assets/javascripts/discourse/lib/autocomplete.js.es6

@@ -6,44 +6,32 @@
 
 export var CANCELLED_STATUS = "__CANCELLED";
 
-var shiftMap = [];
+var keys = {
-shiftMap[192] = "~";
+  backSpace: 8,
-shiftMap[49] = "!";
+  tab: 9,
-shiftMap[50] = "@";
+  enter: 13,
-shiftMap[51] = "#";
+  shift: 16,
-shiftMap[52] = "$";
+  ctrl: 17,
-shiftMap[53] = "%";
+  alt: 18,
-shiftMap[54] = "^";
+  esc: 27,
-shiftMap[55] = "&";
+  space: 32,
-shiftMap[56] = "*";
+  leftWindows: 91,
-shiftMap[57] = "(";
+  rightWindows: 92,
-shiftMap[48] = ")";
+  pageUp: 33,
-shiftMap[109] = "_";
+  pageDown: 34,
-shiftMap[107] = "+";
+  end: 35,
-shiftMap[219] = "{";
+  home: 36,
-shiftMap[221] = "}";
+  leftArrow: 37,
-shiftMap[220] = "|";
+  upArrow: 38,
-shiftMap[59] = ":";
+  rightArrow: 39,
-shiftMap[222] = "\"";
+  downArrow: 40,
-shiftMap[188] = "<";
+  insert: 45,
-shiftMap[190] = ">";
+  deleteKey: 46,
-shiftMap[191] = "?";
+  zero: 48,
-shiftMap[32] = " ";
+  a: 65,
+  z: 90,
+};
 
-function mapKeyPressToActualCharacter(isShiftKey, characterCode) {
-  if ( characterCode === 27 || characterCode === 8 || characterCode === 9 || characterCode === 20 || characterCode === 16 || characterCode === 17 || characterCode === 91 || characterCode === 13 || characterCode === 92 || characterCode === 18 ) { return false; }
-
-  // Lookup non-letter keypress while holding shift
-  if (isShiftKey && ( characterCode < 65 || characterCode > 90 )) {
-    return shiftMap[characterCode];
-  }
-
-  var stringValue = String.fromCharCode(characterCode);
-  if ( !isShiftKey ) {
-    stringValue = stringValue.toLowerCase();
-  }
-  return stringValue;
-}
 
 export default function(options) {
   var autocompletePlugin = this;
@@ -271,17 +259,23 @@ export default function(options) {
   });
 
   $(this).keypress(function(e) {
+    var caretPosition, term;
 
     if (!options.key) return;
 
     // keep hunting backwards till you hit a the @ key
     if (e.which === options.key.charCodeAt(0)) {
-      var caretPosition = Discourse.Utilities.caretPosition(me[0]);
+      caretPosition = Discourse.Utilities.caretPosition(me[0]);
       var prevChar = me.val().charAt(caretPosition - 1);
       if (!prevChar || /\s/.test(prevChar)) {
         completeStart = completeEnd = caretPosition;
         updateAutoComplete(options.dataSource(""));
       }
+    } else if ((completeStart !== null) && (e.charCode !== 0)) {
+      caretPosition = Discourse.Utilities.caretPosition(me[0]),
+      term = me.val().substring(completeStart + (options.key ? 1 : 0), caretPosition);
+      term += String.fromCharCode(e.charCode);
+      updateAutoComplete(options.dataSource(term));
     }
   });
 
@@ -313,8 +307,8 @@ export default function(options) {
     if (!options.key) {
       completeStart = 0;
     }
-    if (e.which === 16) return;
+    if (e.which === keys.shift) return;
-    if ((completeStart === null) && e.which === 8 && options.key) {
+    if ((completeStart === null) && e.which === keys.backSpace && options.key) {
       c = Discourse.Utilities.caretPosition(me[0]);
       next = me[0].value[c];
       c -= 1;
@@ -339,7 +333,7 @@ export default function(options) {
     }
 
     // ESC
-    if (e.which === 27) {
+    if (e.which === keys.escape) {
       if (completeStart !== null) {
         closeAutocomplete();
         return false;
@@ -358,9 +352,9 @@ export default function(options) {
 
       // Keyboard codes! So 80's.
       switch (e.which) {
-        case 13:
+        case keys.enter:
-        case 39:
+        case keys.rightArrow:
-        case 9:
+        case keys.tab:
           if (!autocompleteOptions) return true;
           if (selectedOption >= 0 && (userToComplete = autocompleteOptions[selectedOption])) {
             completeTerm(userToComplete);
@@ -370,14 +364,14 @@ export default function(options) {
           }
           e.stopImmediatePropagation();
           return false;
-        case 38:
+        case keys.upArrow:
           selectedOption = selectedOption - 1;
           if (selectedOption < 0) {
             selectedOption = 0;
           }
           markSelected();
           return false;
-        case 40:
+        case keys.downArrow:
           total = autocompleteOptions.length;
           selectedOption = selectedOption + 1;
           if (selectedOption >= total) {
@@ -388,12 +382,10 @@ export default function(options) {
           }
           markSelected();
           return false;
-        default:
+        case keys.backSpace:
-          // otherwise they're typing - let's search for it!
           completeEnd = caretPosition;
-          if (e.which === 8) {
+          caretPosition--;
-            caretPosition--;
+
-          }
           if (caretPosition < 0) {
             closeAutocomplete();
             if (isInput) {
@@ -404,25 +396,14 @@ export default function(options) {
             }
             return true;
           }
+
           term = me.val().substring(completeStart + (options.key ? 1 : 0), caretPosition);
-          if (e.which >= 48 && e.which <= 90) {
-            term += mapKeyPressToActualCharacter(e.shiftKey, e.which);
-          } else if (e.which === 187) {
-            term += "+";
-          } else if (e.which === 189) {
-            term += (e.shiftKey) ? "_" : "-";
-          } else if (e.which === 220) {
-            term += (e.shiftKey) ? "|" : "]";
-          } else if (e.which === 222) {
-            term += (e.shiftKey) ? "\"" : "'";
-          } else if (!e.which) {
-            /* fake event */
-          } else if (e.which !== 8) {
-            term += ",";
-          }
 
           updateAutoComplete(options.dataSource(term));
           return true;
+        default:
+          completeEnd = caretPosition;
+          return true;
       }
     }
   });