DEV: Allow sidebar section caret title to be translated (#17491)

app/assets/javascripts/discourse/app/templates/components/sidebar/section.hbs

@@ -1,6 +1,6 @@
 <div class={{concat "sidebar-section-wrapper sidebar-section-" @sectionName}}>
   <div class="sidebar-section-header">
-    <button type="button" class="sidebar-section-header-caret" title="toggle section" {{on "click" this.toggleSectionDisplay}}>
+    <button type="button" class="sidebar-section-header-caret" title={{i18n "sidebar.toggle_section"}} {{on "click" this.toggleSectionDisplay}}>
       {{d-icon this.headerCaretIcon}}
     </button>
 

app/assets/javascripts/discourse/tests/acceptance/sidebar-topics-section-test.js

@@ -1,3 +1,5 @@
+import I18n from "I18n";
+
 import { test } from "qunit";
 import { click, currentURL, settled, visit } from "@ember/test-helpers";
 import {
@@ -64,6 +66,12 @@ acceptance("Sidebar - Topics Section", function (needs) {
       "shows content section"
     );
 
+    assert.strictEqual(
+      query(".sidebar-section-topics .sidebar-section-header-caret").title,
+      I18n.t("sidebar.toggle_section"),
+      "caret has the right title"
+    );
+
     await click(".sidebar-section-topics .sidebar-section-header-caret");
 
     assert.ok(

config/locales/client.en.yml

@@ -4054,6 +4054,7 @@ en:
     sidebar:
       unread_count: "%{count} unread"
       new_count: "%{count} new"
+      toggle_section: "toggle section"
       sections:
         messages:
           header_link_title: "personal messages"