DEV: load styleguide assets only when needed (#10918)

This commit is contained in:
Joffrey JAFFEUX 2020-10-14 16:29:40 +02:00 committed by GitHub
parent 74de7a49f5
commit 73d207a568
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 31 additions and 0 deletions

View File

@ -34,6 +34,7 @@ const SERVER_SIDE_ONLY = [
/^\/admin\/logs\/watched_words\/action\/[^\/]+\/download$/,
/^\/pub\//,
/^\/invites\//,
/^\/styleguide\//,
];
// The amount of height (in pixles) that we factor in when jumpEnd is called so

View File

@ -13,3 +13,9 @@ load File.expand_path('../lib/styleguide/engine.rb', __FILE__)
Discourse::Application.routes.append do
mount ::Styleguide::Engine, at: '/styleguide'
end
after_initialize do
register_asset_filter do |type, request|
request&.fullpath&.start_with?('/styleguide')
end
end

View File

@ -0,0 +1,24 @@
# frozen_string_literal: true
require 'rails_helper'
describe 'Styleguide assets' do
before do
SiteSetting.styleguide_enabled = true
sign_in(Fabricate(:admin))
end
context 'visits homepage' do
it 'doesnt load styleguide assets' do
get '/'
expect(response.body).to_not include('styleguide')
end
end
context 'visits styleguide' do
it 'loads styleguide assets' do
get '/styleguide'
expect(response.body).to include('styleguide')
end
end
end