Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Remove `:empty` on topic-statuses, clean up (#14227)

This commit is contained in:
Kris 2021-09-02 15:35:35 -04:00 committed by GitHub
parent 90a23c6fc8
commit 75041dbbeb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 2 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/stylesheets/common/base/_topic-list.scss
View File

@ -287,9 +287,6 @@
line-height: $line-height-large; line-height: $line-height-large;
padding-right: 20px; padding-right: 20px;
} }
.topic-statuses:empty {
display: none;
}
.num { .num {
text-align: center; text-align: center;

7
app/assets/stylesheets/common/base/discourse.scss
View File

@ -829,20 +829,17 @@ table {
} }
.topic-statuses { .topic-statuses {
display: inline; // avoid adding margin/padding on this parent; sometimes it appears as an empty container
float: left; float: left;
margin-right: 0.15em;
.topic-status { .topic-status {
margin: 0; margin: 0;
display: inline-flex; display: inline-flex;
color: var(--primary-medium); color: var(--primary-medium);
margin-right: 0.2em;
.d-icon { .d-icon {
height: 0.74em; height: 0.74em;
width: 0.75em; width: 0.75em;
} }
&:not(:last-child) {
margin-right: 0.15em;
}
} }
.topic-status-warning .d-icon-envelope { .topic-status-warning .d-icon-envelope {

5
app/assets/stylesheets/common/base/reviewables.scss
View File

@ -465,11 +465,6 @@
font-size: $font-up-2; font-size: $font-up-2;
margin-right: 0.75em; margin-right: 0.75em;
} }
.topic-statuses {
&:empty {
display: none;
}
}
} }
} }

4
app/assets/stylesheets/common/base/topic.scss
View File

@ -158,10 +158,6 @@
} }
.topic-statuses { .topic-statuses {
line-height: 1.2; line-height: 1.2;
margin-right: 0.15em;
&:empty {
margin-right: 0;
}
.d-icon { .d-icon {
color: var(--primary-medium); color: var(--primary-medium);
} }

4
app/assets/stylesheets/common/components/bookmark-list.scss
View File

@ -70,10 +70,6 @@ $mobile-breakpoint: 700px;
} }
.topic-statuses { .topic-statuses {
float: none; float: none;
&:empty {
// avoids extra margin
display: none;
}
} }
} }

3
app/assets/stylesheets/desktop/category-list.scss
View File

@ -84,9 +84,6 @@
@include ellipsis; @include ellipsis;
flex: 0 1 auto; flex: 0 1 auto;
} }
.topic-statuses {
margin-right: 0.15em;
}
.topic-post-badges .badge.unread-posts, .topic-post-badges .badge.unread-posts,
.title { .title {
margin-right: 5px; margin-right: 5px;

3
app/assets/stylesheets/desktop/compose.scss
View File

@ -195,9 +195,6 @@
flex: 0 1 auto; flex: 0 1 auto;
margin-right: 0.5em; margin-right: 0.5em;
} }
.topic-statuses:empty {
display: none;
}
span.badge-wrapper { span.badge-wrapper {
margin-left: 0; margin-left: 0;
} }