DEV: Avoid an additional query in `SpamHandler`.

* Also run query against human users only
2020-04-27 13:01:43 +08:00 · 2020-04-27 13:01:43 +08:00 · 76fc48b318
parent e0725fd123
commit 76fc48b318
1 changed files with 1 additions and 2 deletions
--- a/lib/spam_handler.rb
+++ b/lib/spam_handler.rb
@ -11,8 +11,7 @@ class SpamHandler

    return false if tl2_plus_accounts_with_same_ip > 0

-    staff_user_ids = Group[:staff].user_ids - [-1]
-    staff_members_with_same_ip = User.where(id: staff_user_ids)
+    staff_members_with_same_ip = Group[:staff].users.human_users
      .where(ip_address: ip_address.to_s)
      .count