FIX: Return a 404 if the auth session is not present
This commit is contained in:
parent
c182dcc64c
commit
777f1f0f47
|
@ -31,6 +31,8 @@ class Users::OmniauthCallbacksController < ApplicationController
|
|||
|
||||
def complete
|
||||
auth = request.env["omniauth.auth"]
|
||||
raise Discourse::NotFound unless request.env["omniauth.auth"]
|
||||
|
||||
auth[:session] = session
|
||||
|
||||
authenticator = self.class.find_authenticator(params[:provider])
|
||||
|
|
|
@ -16,6 +16,13 @@ RSpec.describe "OmniAuth Callbacks" do
|
|||
SiteSetting.enable_google_oauth2_logins = true
|
||||
end
|
||||
|
||||
context "without an `omniauth.auth` env" do
|
||||
it "should return a 404" do
|
||||
get "/auth/eviltrout/callback"
|
||||
expect(response).not_to be_success
|
||||
end
|
||||
end
|
||||
|
||||
describe 'when user has been verified' do
|
||||
before do
|
||||
OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new(
|
||||
|
|
Loading…
Reference in New Issue