Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: uses hex to compare images 

It prevents some terminals from crashing in case of errors and dumping the whole file content into the terminal.
This commit is contained in:
Joffrey JAFFEUX 2018-11-05 10:12:52 +01:00 committed by Robin Ward
parent 5fc09a6467
commit 78954672f9
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
spec/models/optimized_image_spec.rb
View File

@ -17,9 +17,12 @@ describe OptimizedImage do
5
)
expect(File.read(tmp_path)).to eq(
File.read("#{Rails.root}/spec/fixtures/images/cropped.png")
)
fixture_path = "#{Rails.root}/spec/fixtures/images/cropped.png"
fixture_hex = Digest::MD5.hexdigest(File.read(fixture_path))
cropped_hex = Digest::MD5.hexdigest(File.read(tmp_path))
expect(cropped_hex).to eq(fixture_hex)
ensure
File.delete(tmp_path) if File.exists?(tmp_path)
end
@ -120,9 +123,12 @@ describe OptimizedImage do
"100x100\>"
)
expect(File.read(tmp_path)).to eq(
File.read("#{Rails.root}/spec/fixtures/images/downsized.png")
)
fixture_path = "#{Rails.root}/spec/fixtures/images/downsized.png"
fixture_hex = Digest::MD5.hexdigest(File.read(fixture_path))
downsized_hex = Digest::MD5.hexdigest(File.read(tmp_path))
expect(downsized_hex).to eq(fixture_hex)
ensure
File.delete(tmp_path) if File.exists?(tmp_path)
end