Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-06 11:28:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: UserField#field_type column change to enum migration

Browse Source 
Followup 5963c03643851db4434972cd338d0843fabc5748 and
6be4ef59fac332977d98f7369e1a8c2e7e423be7

This migration was causing issues on deploy for some sites that
had user fields required to be filled in on signup. The Site#user_fields
cache was getting poisoned, and the `field_type` for all fields
was ending up as `null`, making it impossible to fill
them out in a form.

This commit rectifies the issue by doing the column rename/swap
in the initial migration and _only_ dropping columns in the
post migration, since this messes with the AR cache.
This commit is contained in:
Martin Brennan 2024-06-20 11:41:03 +10:00
parent 4ced8f80ac
commit 79344fe212
No known key found for this signature in database
GPG Key ID: BD981EFEEC8F5675
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
db/migrate/20240612063735_add_field_type_enum_to_user_fields.rb
View File

@ -19,5 +19,8 @@ class AddFieldTypeEnumToUserFields < ActiveRecord::Migration[7.0]
change_column_null :user_fields, :field_type, true
change_column_null :user_fields, :field_type_enum, false
end
rename_column :user_fields, :field_type, :field_type_old
rename_column :user_fields, :field_type_enum, :field_type
end
end

3
db/post_migrate/20240612073116_swap_field_type_with_field_type_enum_on_user_fields.rb
View File

@ -1,11 +1,10 @@
# frozen_string_literal: true
class SwapFieldTypeWithFieldTypeEnumOnUserFields < ActiveRecord::Migration[7.0]
DROPPED_COLUMNS ||= { user_fields: %i[field_type] }
DROPPED_COLUMNS ||= { user_fields: %i[field_type_old] }
def up
DROPPED_COLUMNS.each { |table, columns| Migration::ColumnDropper.execute_drop(table, columns) }
rename_column :user_fields, :field_type_enum, :field_type
end
def down