Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix a flaky test (#13580) 

Updated the context name, and fixed a typo that was the source of flakiness.

The error was:
```
  1) TopicView with a few sample posts #first_post_bookmark_reminder_at gets the first post bookmark reminder at for the user
     Failure/Error: expect(second[:reminder_at]).to eq_time(bookmark1.reminder_at)
       2021-07-01 06:49:40 UTC is not within 1 millisecond of 2021-07-01 06:49:39 UTC
     # ./spec/components/topic_view_spec.rb:426:in `block (4 levels) in <main>'
     # ./spec/rails_helper.rb:279:in `block (2 levels) in <top (required)>'
     # ./bundle/ruby/2.7.0/gems/webmock-3.13.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
```
This commit is contained in:
Jarek Radosz 2021-06-30 16:32:28 +02:00 committed by GitHub
parent 11baf872ed
commit 79e850ba19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
spec/components/topic_view_spec.rb
View File

@ -4,7 +4,6 @@ require 'rails_helper'
require 'topic_view' require 'topic_view'
describe TopicView do describe TopicView do
fab!(:user) { Fabricate(:user) } fab!(:user) { Fabricate(:user) }
fab!(:moderator) { Fabricate(:moderator) } fab!(:moderator) { Fabricate(:moderator) }
fab!(:admin) { Fabricate(:admin) } fab!(:admin) { Fabricate(:admin) }
@ -219,7 +218,6 @@ describe TopicView do
PostActionCreator.like(moderator, p2) PostActionCreator.like(moderator, p2)
best = TopicView.new(topic.id, nil, best: 99, only_moderator_liked: true) best = TopicView.new(topic.id, nil, best: 99, only_moderator_liked: true)
expect(best.posts.count).to eq(1) expect(best.posts.count).to eq(1)
end end
it "raises NotLoggedIn if the user isn't logged in and is trying to view a private message" do it "raises NotLoggedIn if the user isn't logged in and is trying to view a private message" do
@ -410,7 +408,7 @@ describe TopicView do
end end
end end
context "#first_post_bookmark_reminder_at" do context "#bookmarked_posts" do
let!(:user) { Fabricate(:user) } let!(:user) { Fabricate(:user) }
let!(:bookmark1) { Fabricate(:bookmark_next_business_day_reminder, post: topic.first_post, user: user) } let!(:bookmark1) { Fabricate(:bookmark_next_business_day_reminder, post: topic.first_post, user: user) }
let!(:bookmark2) { Fabricate(:bookmark_next_business_day_reminder, post: topic.posts[1], user: user) } let!(:bookmark2) { Fabricate(:bookmark_next_business_day_reminder, post: topic.posts[1], user: user) }
@ -418,12 +416,11 @@ describe TopicView do
it "gets the first post bookmark reminder at for the user" do it "gets the first post bookmark reminder at for the user" do
topic_view = TopicView.new(topic.id, user) topic_view = TopicView.new(topic.id, user)
bookmarked_posts = topic_view.bookmarked_posts first, second = topic_view.bookmarked_posts
first, second = bookmarked_posts
expect(first[:post_id]).to eq(bookmark1.post_id) expect(first[:post_id]).to eq(bookmark1.post_id)
expect(first[:reminder_at]).to eq_time(bookmark1.reminder_at) expect(first[:reminder_at]).to eq_time(bookmark1.reminder_at)
expect(second[:post_id]).to eq(bookmark2.post_id) expect(second[:post_id]).to eq(bookmark2.post_id)
expect(second[:reminder_at]).to eq_time(bookmark1.reminder_at) expect(second[:reminder_at]).to eq_time(bookmark2.reminder_at)
end end
context "when the topic is deleted" do context "when the topic is deleted" do
@ -432,12 +429,11 @@ describe TopicView do
PostDestroyer.new(Fabricate(:admin), topic.first_post).destroy PostDestroyer.new(Fabricate(:admin), topic.first_post).destroy
topic.reload topic.reload
bookmarked_posts = topic_view.bookmarked_posts first, second = topic_view.bookmarked_posts
first, second = bookmarked_posts
expect(first[:post_id]).to eq(bookmark1.post_id) expect(first[:post_id]).to eq(bookmark1.post_id)
expect(first[:reminder_at]).to eq_time(bookmark1.reminder_at) expect(first[:reminder_at]).to eq_time(bookmark1.reminder_at)
expect(second[:post_id]).to eq(bookmark2.post_id) expect(second[:post_id]).to eq(bookmark2.post_id)
expect(second[:reminder_at]).to eq_time(bookmark1.reminder_at) expect(second[:reminder_at]).to eq_time(bookmark2.reminder_at)
end end
end end
end end
@ -467,7 +463,6 @@ describe TopicView do
expect(recent_posts.first.created_at).to be > recent_posts.last.created_at expect(recent_posts.first.created_at).to be > recent_posts.last.created_at
end end
end end
end end
context 'whispers' do context 'whispers' do
@ -591,7 +586,6 @@ describe TopicView do
end end
describe "filter_posts_near" do describe "filter_posts_near" do
def topic_view_near(post, show_deleted = false) def topic_view_near(post, show_deleted = false)
TopicView.new(topic.id, evil_trout, post_number: post.post_number, show_deleted: show_deleted) TopicView.new(topic.id, evil_trout, post_number: post.post_number, show_deleted: show_deleted)
end end