Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Auto grid images no longer experimental (#29572) 

Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore.

This PR removes the site setting `experimental_auto_grid_images`.
This commit is contained in:
Keegan George 2024-11-05 01:21:40 +09:00 committed by GitHub
parent 1d637c5243
commit 7a936da05c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/app/lib/uppy/composer-upload.js
View File

@ -352,10 +352,7 @@ export default class UppyComposerUpload {
});
const MIN_IMAGES_TO_AUTO_GRID = 3;
if (
this.siteSettings.experimental_auto_grid_images &&
this.#consecutiveImages?.length >= MIN_IMAGES_TO_AUTO_GRID
) {
if (this.#consecutiveImages?.length >= MIN_IMAGES_TO_AUTO_GRID) {
this.#autoGridImages();
}
});

1
config/locales/server.en.yml
View File

@ -2728,7 +2728,6 @@ en:
experimental_form_templates: "EXPERIMENTAL: Enable the form templates feature. <b>After enabled,</b> manage the templates at <a href='%{base_path}/admin/customize/form-templates'>Customize / Templates</a>."
admin_sidebar_enabled_groups: "Enable sidebar navigation for the admin UI for the specified groups, which replaces the top-level admin navigation buttons."
lazy_load_categories_groups: "EXPERIMENTAL: Lazy load category information only for users of these groups. This improves performance on sites with many categories."
experimental_auto_grid_images: "EXPERIMENTAL: Automatically wraps images in [grid] tags when 3 or more images are uploaded in the composer."
page_loading_indicator: "Configure the loading indicator which appears during page navigations within Discourse. 'Spinner' is a full page indicator. 'Slider' shows a narrow bar at the top of the screen."
show_user_menu_avatars: "Show user avatars in the user menu"

3
config/site_settings.yml
View File

@ -2471,9 +2471,6 @@ developer:
default: 50
hidden: true
client: true
experimental_auto_grid_images:
default: false
client: true
navigation:
navigation_menu:

4
spec/system/composer_uploads_spec.rb
View File

@ -160,8 +160,6 @@ describe "Uploading files in the composer", type: :system do
end
context "when multiple images are uploaded" do
before { SiteSetting.experimental_auto_grid_images = true }
it "automatically wraps images in [grid] tags on 3 or more images" do
visit "/new-topic"
expect(composer).to be_opened
@ -227,8 +225,6 @@ describe "Uploading files in the composer", type: :system do
end
it "does not automatically wrap images in [grid] tags when setting is disabled" do
SiteSetting.experimental_auto_grid_images = false
visit "/new-topic"
expect(composer).to be_opened