diff --git a/app/assets/javascripts/discourse/app/components/emoji-picker.js b/app/assets/javascripts/discourse/app/components/emoji-picker.js index 0d194c6bcdd..8553dbca370 100644 --- a/app/assets/javascripts/discourse/app/components/emoji-picker.js +++ b/app/assets/javascripts/discourse/app/components/emoji-picker.js @@ -36,7 +36,6 @@ export default Component.extend({ recentEmojis: null, hoveredEmoji: null, isActive: false, - isLoading: true, usePopper: true, initialFilter: "", @@ -79,7 +78,6 @@ export default Component.extend({ @action onShow() { - this.set("isLoading", true); this.set("recentEmojis", this.emojiStore.favorites); schedule("afterRender", () => { @@ -135,8 +133,6 @@ export default Component.extend({ // this is a low-tech trick to prevent appending hundreds of emojis // of blocking the rendering of the picker later(() => { - this.set("isLoading", false); - schedule("afterRender", () => { if (!this.site.isMobileDevice || this.isEditorFocused) { const filter = emojiPicker.querySelector("input.filter"); diff --git a/app/assets/javascripts/discourse/app/templates/components/emoji-picker.hbs b/app/assets/javascripts/discourse/app/templates/components/emoji-picker.hbs index c64d59e4853..2ee960167ba 100644 --- a/app/assets/javascripts/discourse/app/templates/components/emoji-picker.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/emoji-picker.hbs @@ -38,42 +38,40 @@
- {{#conditional-loading-spinner condition=isLoading}} -
- {{#if recentEmojis.length}} -
-
- {{i18n "emoji_picker.recent"}} - {{d-button icon="trash-alt" action=(action "onClearRecents") class="trash-recent"}} -
+
+ {{#if recentEmojis.length}} +
+
+ {{i18n "emoji_picker.recent"}} + {{d-button icon="trash-alt" action=(action "onClearRecents") class="trash-recent"}} +
+
+ {{#each recentEmojis as |emoji|}} + {{replace-emoji (concat ":" emoji ":") (hash lazy=true)}} + {{/each}} +
+
+ {{/if}} + + {{emoji-group-sections}} + + {{#each-in customEmojis as |group emojis|}} +
+
+ + {{i18n (concat "emoji_picker." group)}} + +
+ {{#if emojis.length}}
- {{#each recentEmojis as |emoji|}} - {{replace-emoji (concat ":" emoji ":") (hash lazy=true)}} + {{#each emojis as |emoji|}} + {{/each}}
-
- {{/if}} - - {{emoji-group-sections}} - - {{#each-in customEmojis as |group emojis|}} -
-
- - {{i18n (concat "emoji_picker." group)}} - -
- {{#if emojis.length}} -
- {{#each emojis as |emoji|}} - - {{/each}} -
- {{/if}} -
- {{/each-in}} -
- {{/conditional-loading-spinner}} + {{/if}} +
+ {{/each-in}} +