Merge pull request #1079 from ZogStriP/do-not-lightbox-oneboxed-images

do not lightbox oneboxed images
This commit is contained in:
Sam 2013-06-23 22:07:25 -07:00
commit 7c726bd235
3 changed files with 24 additions and 1 deletions

View File

@ -22,7 +22,7 @@ class CookedPostProcessor
end
def post_process_images
images = @doc.search("img")
images = @doc.css("img") - @doc.css(".onebox-result img")
return unless images.present?
images.each do |img|

View File

@ -111,6 +111,21 @@ describe CookedPostProcessor do
end
end
context 'with a oneboxed image' do
let(:user) { Fabricate(:user) }
let(:topic) { Fabricate(:topic, user: user) }
let(:post) { Fabricate.build(:post_with_oneboxed_image, topic: topic, user: user) }
let(:processor) { CookedPostProcessor.new(post) }
before do
processor.post_process_images
end
it "doesn't lightbox" do
processor.html.should_not =~ /class="lightbox"/
end
end
end
context 'link convertor' do

View File

@ -46,6 +46,14 @@ Fabricator(:post_with_uploads, from: :post) do
"
end
Fabricator(:post_with_oneboxed_image, from: :post) do
cooked "
<div class='onebox-result'>
<img src='/uploads/default/1/1234567890123456.jpg' height='100' width='100'>
</div>
"
end
Fabricator(:basic_reply, from: :post) do
user(:coding_horror)