Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Update webhook site setting for topic voting (#27935)

This commit is contained in:
Natalie Tay 2024-07-17 20:26:48 +08:00 committed by GitHub
parent a714ca9759
commit 7d02b45304
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/web_hook_event_type.rb
View File

@ -103,7 +103,7 @@ class WebHookEventType < ActiveRecord::Base
unless defined?(SiteSetting.assign_enabled) && SiteSetting.assign_enabled unless defined?(SiteSetting.assign_enabled) && SiteSetting.assign_enabled
ids_to_exclude.concat([TYPES[:assign_assigned], TYPES[:assign_unassigned]]) ids_to_exclude.concat([TYPES[:assign_assigned], TYPES[:assign_unassigned]])
end end
unless defined?(SiteSetting.voting_enabled) && SiteSetting.voting_enabled unless defined?(SiteSetting.topic_voting_enabled) && SiteSetting.topic_voting_enabled
ids_to_exclude.concat([TYPES[:voting_topic_upvote], TYPES[:voting_topic_unvote]]) ids_to_exclude.concat([TYPES[:voting_topic_upvote], TYPES[:voting_topic_unvote]])
end end
unless defined?(SiteSetting.chat_enabled) && SiteSetting.chat_enabled unless defined?(SiteSetting.chat_enabled) && SiteSetting.chat_enabled

6
spec/models/web_hook_event_type_spec.rb
View File

@ -4,7 +4,7 @@ RSpec.describe WebHookEventType do
describe "#active" do describe "#active" do
it "returns only active types" do it "returns only active types" do
core_event_types = WebHookEventType.active.map(&:name) core_event_types = WebHookEventType.active.map(&:name)
expect(core_event_types).to eq( expect(core_event_types).to match_array(
%w[ %w[
topic_created topic_created
topic_revised topic_revised
@ -47,10 +47,10 @@ RSpec.describe WebHookEventType do
SiteSetting.stubs(:solved_enabled).returns(true) SiteSetting.stubs(:solved_enabled).returns(true)
SiteSetting.stubs(:assign_enabled).returns(true) SiteSetting.stubs(:assign_enabled).returns(true)
SiteSetting.stubs(:voting_enabled).returns(true) SiteSetting.stubs(:topic_voting_enabled).returns(true)
SiteSetting.stubs(:chat_enabled).returns(true) SiteSetting.stubs(:chat_enabled).returns(true)
plugins_event_types = WebHookEventType.active.map(&:name) - core_event_types plugins_event_types = WebHookEventType.active.map(&:name) - core_event_types
expect(plugins_event_types).to eq( expect(plugins_event_types).to match_array(
%w[ %w[
accepted_solution accepted_solution
unaccepted_solution unaccepted_solution

2
spec/models/web_hook_spec.rb
View File

@ -57,7 +57,7 @@ RSpec.describe WebHook do
assign_event_types = WebHookEventType.active.where(group: "assign").pluck(:name) assign_event_types = WebHookEventType.active.where(group: "assign").pluck(:name)
expect(assign_event_types).to eq(%w[assigned unassigned]) expect(assign_event_types).to eq(%w[assigned unassigned])
SiteSetting.stubs(:voting_enabled).returns(true) SiteSetting.stubs(:topic_voting_enabled).returns(true)
voting_event_types = WebHookEventType.active.where(group: "voting").pluck(:name) voting_event_types = WebHookEventType.active.where(group: "voting").pluck(:name)
expect(voting_event_types).to eq(%w[topic_upvote topic_unvote]) expect(voting_event_types).to eq(%w[topic_upvote topic_unvote])
# #