Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-20 18:58:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5493 from notriddle/home_logo_h1

Browse Source 
Change the text-only home logo to an H1
This commit is contained in:
Jeff Atwood 2018-01-18 16:14:36 -08:00 committed by GitHub
commit 7ed41fae2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/widgets/home-logo.js.es6
View File

@ -38,7 +38,7 @@ export default createWidget('home-logo', {
} else if (logoUrl.length) {
return h('img#site-logo.logo-big', { key: 'logo-big', attributes: { src: logoUrl, alt: title } });
} else {
return h('h2#site-text-logo.text-logo', { key: 'logo-text' }, title);
return h('h1#site-text-logo.text-logo', { key: 'logo-text' }, title);
}
},

1
app/assets/stylesheets/desktop/header.scss
View File

@ -43,6 +43,7 @@ and (max-width : 570px) {
header {
#site-text-logo {
font-size: $font-up-3;
margin-top: .4em;
line-height: $line-height-medium;
}

2
app/assets/stylesheets/mobile/discourse.scss
View File

@ -154,6 +154,6 @@ blockquote {
// somehow the image logo assumption inherits margins from earlier in the CSS
// stack we must remove margins for text site titles
h2#site-text-logo {
h1#site-text-logo {
margin: 0 0 0 10px;
}

3
app/assets/stylesheets/mobile/header.scss
View File

@ -2,6 +2,9 @@
// Discourse header
// --------------------------------------------------
#site-text-logo {
font-size: $font-up-3;
}
@media only screen and (max-width: 320px) {
#site-text-logo {
font-size: $font-up-2;

2
test/javascripts/widgets/home-logo-test.js.es6
View File

@ -51,7 +51,7 @@ widgetTest('no logo', {
},
test(assert) {
assert.ok(this.$('h2#site-text-logo.text-logo').length === 1);
assert.ok(this.$('h1#site-text-logo.text-logo').length === 1);
assert.equal(this.$('#site-text-logo').text(), title);
}
});