Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SearchLog: fix specs

This commit is contained in:
riking 2018-05-21 12:22:11 -07:00 committed by Sam
parent 38a8e52ca4
commit 7f37ee9152
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/search_log.rb
View File

@ -1,7 +1,7 @@
require_dependency 'enum'
class SearchLog < ActiveRecord::Base
validates_presence_of :term, :ip_address
validates_presence_of :term
def self.search_types
@search_types ||= Enum.new(

6
spec/models/search_log_spec.rb
View File

@ -101,7 +101,7 @@ RSpec.describe SearchLog, type: :model do
log = SearchLog.find(log_id)
expect(log.term).to eq('hello')
expect(log.search_type).to eq(SearchLog.search_types[:full_page])
expect(log.ip_address).to eq('192.168.0.1')
expect(log.ip_address).to eq(nil)
expect(log.user_id).to eq(user.id)
action, updated_log_id = SearchLog.log(
@ -183,11 +183,12 @@ RSpec.describe SearchLog, type: :model do
end
context "trending" do
let(:user) { Fabricate(:user) }
before do
SearchLog.log(term: 'ruby', search_type: :header, ip_address: '127.0.0.1')
SearchLog.log(term: 'php', search_type: :header, ip_address: '127.0.0.1')
SearchLog.log(term: 'java', search_type: :header, ip_address: '127.0.0.1')
SearchLog.log(term: 'ruby', search_type: :header, ip_address: '127.0.0.1', user_id: Fabricate(:user).id)
SearchLog.log(term: 'ruby', search_type: :header, ip_address: '127.0.0.1', user_id: user.id)
SearchLog.log(term: 'swift', search_type: :header, ip_address: '127.0.0.1')
SearchLog.log(term: 'ruby', search_type: :header, ip_address: '127.0.0.2')
end
@ -207,6 +208,7 @@ RSpec.describe SearchLog, type: :model do
expect(top_trending.click_through).to eq(0)
SearchLog.where(term: 'ruby', ip_address: '127.0.0.1').update_all(search_result_id: 12)
SearchLog.where(term: 'ruby', user_id: user.id).update_all(search_result_id: 12)
SearchLog.where(term: 'ruby', ip_address: '127.0.0.2').update_all(search_result_id: 24)
top_trending = SearchLog.trending.first
expect(top_trending.click_through).to eq(3)