DEV: rename refresh action to avoid regressions in the future (#14721)

app/assets/javascripts/discourse/app/controllers/tags-index.js

@@ -96,7 +96,7 @@ export default Controller.extend({
             (proceed) => {
               if (proceed) {
                 ajax("/tags/unused", { type: "DELETE" })
-                  .then(() => this.send("refresh"))
+                  .then(() => this.send("triggerRefresh"))
                   .catch(popupAjaxError);
               }
             }

app/assets/javascripts/discourse/app/routes/tags-index.js

@@ -1,6 +1,7 @@
 import DiscourseRoute from "discourse/routes/discourse";
 import I18n from "I18n";
 import Tag from "discourse/models/tag";
+import { action } from "@ember/object";
 
 export default DiscourseRoute.extend({
   model() {
@@ -34,19 +35,20 @@ export default DiscourseRoute.extend({
     });
   },
 
-  actions: {
-    didTransition() {
-      this.controllerFor("application").set("showFooter", true);
-      return true;
-    },
+  @action
+  didTransition() {
+    this.controllerFor("application").set("showFooter", true);
+    return true;
+  },
 
-    showTagGroups() {
-      this.transitionTo("tagGroups");
-      return true;
-    },
+  @action
+  showTagGroups() {
+    this.transitionTo("tagGroups");
+    return true;
+  },
 
-    refresh() {
-      this.refresh();
-    },
+  @action
+  triggerRefresh() {
+    this.refresh();
   },
 });

app/assets/javascripts/discourse/app/templates/modal/tag-upload.hbs

@@ -1,3 +1,3 @@
 {{#d-modal-body title="tagging.upload"}}
-  {{tags-uploader refresh=(route-action "refresh") closeModal=(route-action "closeModal")}}
+  {{tags-uploader refresh=(route-action "triggerRefresh") closeModal=(route-action "closeModal")}}
 {{/d-modal-body}}