diff --git a/app/assets/javascripts/discourse/app/index.html b/app/assets/javascripts/discourse/app/index.html index ba049ba54ce..0dde7cb0ab4 100644 --- a/app/assets/javascripts/discourse/app/index.html +++ b/app/assets/javascripts/discourse/app/index.html @@ -11,8 +11,10 @@ {{content-for "before-script-load"}} - - + + + + {{content-for "head"}} @@ -27,7 +29,7 @@ - + {{content-for "body-footer"}} diff --git a/app/assets/javascripts/discourse/ember-cli-build.js b/app/assets/javascripts/discourse/ember-cli-build.js index d9232652ab8..7065afc5573 100644 --- a/app/assets/javascripts/discourse/ember-cli-build.js +++ b/app/assets/javascripts/discourse/ember-cli-build.js @@ -29,6 +29,7 @@ module.exports = function (defaults) { }, autoImport: { forbidEval: true, + insertScriptsAt: "ember-auto-import-scripts", }, fingerprint: { // Handled by Rails asset pipeline diff --git a/app/assets/javascripts/discourse/lib/bootstrap-json/index.js b/app/assets/javascripts/discourse/lib/bootstrap-json/index.js index a1fcc954366..46c891ecc6a 100644 --- a/app/assets/javascripts/discourse/lib/bootstrap-json/index.js +++ b/app/assets/javascripts/discourse/lib/bootstrap-json/index.js @@ -89,7 +89,7 @@ function head(buffer, bootstrap, headers, baseURL) { let { admin, staff } = user; if (staff) { - buffer.push(``); + buffer.push(``); } if (admin) { @@ -98,7 +98,7 @@ function head(buffer, bootstrap, headers, baseURL) { } bootstrap.plugin_js.forEach((src) => - buffer.push(``) + buffer.push(``) ); buffer.push(bootstrap.theme_html.translations); @@ -108,14 +108,14 @@ function head(buffer, bootstrap, headers, baseURL) { } function localeScript(buffer, bootstrap) { - buffer.push(``); + buffer.push(``); } function beforeScriptLoad(buffer, bootstrap) { buffer.push(bootstrap.html.before_script_load); localeScript(buffer, bootstrap); (bootstrap.extra_locales || []).forEach((l) => - buffer.push(``) + buffer.push(``) ); } diff --git a/app/assets/javascripts/discourse/tests/index.html b/app/assets/javascripts/discourse/tests/index.html index cc64b777149..8917097f05c 100644 --- a/app/assets/javascripts/discourse/tests/index.html +++ b/app/assets/javascripts/discourse/tests/index.html @@ -46,7 +46,9 @@ + + diff --git a/app/assets/javascripts/discourse/tests/test_starter.js b/app/assets/javascripts/discourse/tests/test_starter.js index 0ab61639ba7..067e890fc16 100644 --- a/app/assets/javascripts/discourse/tests/test_starter.js +++ b/app/assets/javascripts/discourse/tests/test_starter.js @@ -1,10 +1,11 @@ // discourse-skip-module -document.write( - '
' -); -document.write( - "" +document.body.insertAdjacentHTML( + "afterbegin", + ` +
+ + ` ); let setupTestsLegacy = require("discourse/tests/setup-tests").setupTestsLegacy; diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 5773efd851f..f069f5560c1 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -153,7 +153,7 @@ module ApplicationHelper def preload_script_url(url) <<~HTML.html_safe - + HTML end diff --git a/app/models/theme.rb b/app/models/theme.rb index 5c510086f7f..6488b36e52d 100644 --- a/app/models/theme.rb +++ b/app/models/theme.rb @@ -154,7 +154,7 @@ class Theme < ActiveRecord::Base SvgSprite.expire_cache end - BASE_COMPILER_VERSION = 55 + BASE_COMPILER_VERSION = 56 def self.compiler_version get_set_cache "compiler_version" do dependencies = [ @@ -391,7 +391,7 @@ class Theme < ActiveRecord::Base end caches = JavascriptCache.where(theme_id: theme_ids) caches = caches.sort_by { |cache| theme_ids.index(cache.theme_id) } - return caches.map { |c| "" }.join("\n") + return caches.map { |c| "" }.join("\n") end list_baked_fields(theme_ids, target, name).map { |f| f.value_baked || f.value }.join("\n") end diff --git a/app/models/theme_field.rb b/app/models/theme_field.rb index bdc017c6617..a48b5f92186 100644 --- a/app/models/theme_field.rb +++ b/app/models/theme_field.rb @@ -149,7 +149,7 @@ class ThemeField < ActiveRecord::Base javascript_cache.content = js_compiler.content javascript_cache.save! - doc.add_child("") if javascript_cache.content.present? + doc.add_child("") if javascript_cache.content.present? [doc.to_s, errors&.join("\n")] end @@ -265,7 +265,7 @@ class ThemeField < ActiveRecord::Base javascript_cache.content = js_compiler.content javascript_cache.save! doc = "" - doc = "" if javascript_cache.content.present? + doc = "" if javascript_cache.content.present? [doc, errors&.join("\n")] end diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 83e56dff16e..0ab67a126c0 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -112,11 +112,11 @@ - + <%= yield :data %> - + <%- unless customization_disabled? %> <%= theme_lookup("body_tag") %> diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index e7af0c68118..fdf4ce1faa2 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -7,7 +7,7 @@ describe ApplicationHelper do def preload_link(url) <<~HTML - + HTML end diff --git a/spec/models/theme_field_spec.rb b/spec/models/theme_field_spec.rb index ad43c0d1e09..c4eca24304e 100644 --- a/spec/models/theme_field_spec.rb +++ b/spec/models/theme_field_spec.rb @@ -75,7 +75,7 @@ describe ThemeField do theme_field = ThemeField.create!(theme_id: 1, target_id: 0, name: "header", value: html) theme_field.ensure_baked! - expect(theme_field.value_baked).to include("") + expect(theme_field.value_baked).to include("") expect(theme_field.value_baked).to include("external-script.js") expect(theme_field.value_baked).to include('") + expect(field.value_baked).to include("") expect(field.javascript_cache.content).to include("Theme Transpilation Error:") field.update!(value: '') @@ -130,7 +130,7 @@ HTML theme_field.ensure_baked! javascript_cache = theme_field.javascript_cache - expect(theme_field.value_baked).to include("") + expect(theme_field.value_baked).to include("") expect(javascript_cache.content).to include("testing-div") expect(javascript_cache.content).to include("string_setting") expect(javascript_cache.content).to include("test text \\\" 123!") @@ -378,7 +378,7 @@ HTML describe "javascript cache" do it "is generated correctly" do fr1.ensure_baked! - expect(fr1.value_baked).to include("") + expect(fr1.value_baked).to include("") expect(fr1.javascript_cache.content).to include("bonjourworld") expect(fr1.javascript_cache.content).to include("helloworld") expect(fr1.javascript_cache.content).to include("enval1")