Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Reinstate Chat::MessageCreator skipped thread specs (#21718) 

Followup to 7f85624a01

Fixes the specs that were skipped and reinstates them
This commit is contained in:
Martin Brennan 2023-05-24 10:59:11 +02:00 committed by GitHub
parent 177d8dfcd1
commit 8076a84ff0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/chat/spec/components/chat/message_creator_spec.rb
View File

@ -726,7 +726,13 @@ describe Chat::MessageCreator do
end end
it "creates a thread and updates all the messages in the chain" do it "creates a thread and updates all the messages in the chain" do
skip "TODO: a recent spec regression" # This must be done since the fabricator uses Chat::MessageCreator
# under the hood and it creates the thread already.
old_message_1.update!(thread_id: nil)
old_message_2.update!(thread_id: nil)
old_message_3.update!(thread_id: nil)
reply_message.update!(thread_id: nil)
thread_count = Chat::Thread.count thread_count = Chat::Thread.count
message = message =
described_class.create( described_class.create(
@ -851,11 +857,11 @@ describe Chat::MessageCreator do
before do before do
old_message_1.update!(thread: old_thread) old_message_1.update!(thread: old_thread)
old_message_2.update!(thread: old_thread)
old_message_3.update!(thread: incorrect_thread) old_message_3.update!(thread: incorrect_thread)
end end
it "does not change any messages in the chain, assumes they have the correct thread ID" do it "does not change any messages in the chain, assumes they have the correct thread ID" do
skip "TODO: a recent spec regression"
thread_count = Chat::Thread.count thread_count = Chat::Thread.count
message = message =
described_class.create( described_class.create(