From 81de59280448f8571d33aa7fd0856e3ee8481a9e Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Fri, 29 May 2020 15:46:12 +0800 Subject: [PATCH] PERF: Use more efficient query when checking for existence. --- app/controllers/invites_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/invites_controller.rb b/app/controllers/invites_controller.rb index a1bbedc5ce1..a21b3af3460 100644 --- a/app/controllers/invites_controller.rb +++ b/app/controllers/invites_controller.rb @@ -84,7 +84,7 @@ class InvitesController < ApplicationController guardian.ensure_can_invite_to_forum!(groups) group_ids = groups.map(&:id) - invite_exists = Invite.where(email: params[:email], invited_by_id: current_user.id).first + invite_exists = Invite.exists?(email: params[:email], invited_by_id: current_user.id) if invite_exists && !guardian.can_send_multiple_invites?(current_user) return render json: failed_json, status: 422 end @@ -114,7 +114,7 @@ class InvitesController < ApplicationController group_ids = groups.map(&:id) - invite_exists = Invite.where(email: params[:email], invited_by_id: current_user.id).first + invite_exists = Invite.exists?(email: params[:email], invited_by_id: current_user.id) if invite_exists && !guardian.can_send_multiple_invites?(current_user) return render json: failed_json, status: 422 end