Improve specs to test for the right response status.

spec/controllers/user_badges_controller_spec.rb

@@ -22,7 +22,7 @@ describe UserBadgesController do
     it "fails when badges are disabled" do
       SiteSetting.enable_badges = false
       get :index, params: { badge_id: badge.id }, format: :json
-      expect(response).not_to be_success
+      expect(response.status).to eq(404)
     end
   end
 

spec/requests/users_controller_spec.rb

@@ -35,7 +35,7 @@ RSpec.describe UsersController do
     it "fails if badges are disabled" do
       SiteSetting.enable_badges = false
       get "/u/#{user.username}/badges"
-      expect(response).not_to be_success
+      expect(response.status).to eq(404)
     end
   end