From 82a6176b086a69b768c21b17c8e44ca4a7f7fd7b Mon Sep 17 00:00:00 2001 From: Sam Date: Wed, 19 Aug 2015 12:32:31 +1000 Subject: [PATCH] lower the volume on failed to pull hotlinked image add more diagnostics --- app/jobs/regular/pull_hotlinked_images.rb | 6 +++--- config/initializers/logster.rb | 5 +---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/app/jobs/regular/pull_hotlinked_images.rb b/app/jobs/regular/pull_hotlinked_images.rb index 87a63b98550..efe7457e5c3 100644 --- a/app/jobs/regular/pull_hotlinked_images.rb +++ b/app/jobs/regular/pull_hotlinked_images.rb @@ -41,10 +41,10 @@ module Jobs upload = Upload.create_for(post.user_id, hotlinked, filename, File.size(hotlinked.path), { origin: src }) downloaded_urls[src] = upload.url else - Rails.logger.error("Failed to pull hotlinked image: #{src} - Image is bigger than #{@max_size}") + Rails.logger.info("Failed to pull hotlinked image for post: #{post_id}: #{src} - Image is bigger than #{@max_size}") end else - Rails.logger.error("There was an error while downloading '#{src}' locally.") + Rails.logger.error("There was an error while downloading '#{src}' locally for post: #{post_id}") end end # have we successfully downloaded that file? @@ -66,7 +66,7 @@ module Jobs raw.gsub!(src, "") end rescue => e - Rails.logger.error("Failed to pull hotlinked image: #{src}\n" + e.message + "\n" + e.backtrace.join("\n")) + Rails.logger.info("Failed to pull hotlinked image: #{src} post:#{post_id}\n" + e.message + "\n" + e.backtrace.join("\n")) ensure # close & delete the temp file hotlinked && hotlinked.close! diff --git a/config/initializers/logster.rb b/config/initializers/logster.rb index e3e748faa65..2daf7200fe0 100644 --- a/config/initializers/logster.rb +++ b/config/initializers/logster.rb @@ -31,10 +31,7 @@ if Rails.env.production? /^ActiveRecord::RecordNotFound /, # bad asset requested, no need to log - /^ActionController::BadRequest /, - - # hotlinked image error that is pointless - /^Failed to pull hotlinked image.*(404 Not Found|403 Forbidden|gestaddrinfo: Name or service not known)/m + /^ActionController::BadRequest / ] end