Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-06 03:18:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Don't use :true/:false symbols (#24861)

Browse Source 
on line 252 `has_children` is set to true/false (actual booleans) which means `has_children?` was in some cases returning incorrect value…
This commit is contained in:
Jarek Radosz 2023-12-13 00:27:14 +01:00 committed by GitHub
parent 607c530252
commit 8355664c82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/category.rb
View File

@ -886,8 +886,8 @@ class Category < ActiveRecord::Base
end end
def has_children? def has_children?
@has_children ||= (id && Category.where(parent_category_id: id).exists?) ? :true : :false return @has_children if defined?(@has_children)
@has_children == :true @has_children = (id && Category.where(parent_category_id: id).exists?)
end end
def uncategorized? def uncategorized?