Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Avoid waiting full capybara default wait time (#21842) 

Avoid using negated matchers with custom RSpec matchers that rely on
`has_css?` as it'll result in Capybara waiting the full default wait
time.
This commit is contained in:
Alan Guo Xiang Tan 2023-05-31 08:00:16 +09:00 committed by GitHub
parent 852086e888
commit 83af25179d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spec/system/composer/category_templates_spec.rb
View File

@ -88,7 +88,7 @@ describe "Composer Form Templates", type: :system, js: true do
it "shows a form when a form template is assigned to the category" do it "shows a form when a form template is assigned to the category" do
category_page.visit(category_with_template_1) category_page.visit(category_with_template_1)
category_page.new_topic_button.click category_page.new_topic_button.click
expect(composer).not_to have_composer_input expect(composer).to have_no_composer_input
expect(composer).to have_form_template expect(composer).to have_form_template
expect(composer).to have_form_template_field("checkbox") expect(composer).to have_form_template_field("checkbox")
end end
@ -115,7 +115,7 @@ describe "Composer Form Templates", type: :system, js: true do
it "does not show form template chooser when a category only has form template" do it "does not show form template chooser when a category only has form template" do
category_page.visit(category_with_template_1) category_page.visit(category_with_template_1)
category_page.new_topic_button.click category_page.new_topic_button.click
expect(composer).not_to have_form_template_chooser expect(composer).to have_no_form_template_chooser
end end
it "shows form template chooser when a category has multiple form templates" do it "shows form template chooser when a category has multiple form templates" do

16
spec/system/page_objects/components/composer.rb
View File

@ -103,8 +103,14 @@ module PageObjects
page.has_no_css?(emoji_preview_selector(emoji)) page.has_no_css?(emoji_preview_selector(emoji))
end end
COMPOSER_INPUT_SELECTOR = "#{COMPOSER_ID} .d-editor-input"
def has_no_composer_input?
page.has_no_css?(COMPOSER_INPUT_SELECTOR)
end
def has_composer_input? def has_composer_input?
page.has_css?("#{COMPOSER_ID} .d-editor .d-editor-input") page.has_css?(COMPOSER_INPUT_SELECTOR)
end end
def has_form_template? def has_form_template?
@ -115,8 +121,14 @@ module PageObjects
page.has_css?(".form-template-field[data-field-type='#{field}']") page.has_css?(".form-template-field[data-field-type='#{field}']")
end end
FORM_TEMPLATE_CHOOSER_SELECTOR = ".composer-select-form-template"
def has_no_form_template_chooser?
page.has_no_css?(FORM_TEMPLATE_CHOOSER_SELECTOR)
end
def has_form_template_chooser? def has_form_template_chooser?
page.has_css?(".composer-select-form-template") page.has_css?(FORM_TEMPLATE_CHOOSER_SELECTOR)
end end
def composer_input def composer_input