DEV: Remove unused JS style rspec test (#20280)

This hasn't functioned since we removed the `.es6` extensions from our JS files. Plus, during the migration from classic reactivity to octane, there are legitimate reasons to use `this.get` for single properties of Ember Objects
This commit is contained in:
David Taylor 2023-02-14 11:21:59 +00:00 committed by GitHub
parent 6595374e49
commit 842bf8abd6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 19 deletions

View File

@ -4,10 +4,6 @@ def list_files(base_dir, pattern = "*")
Dir[File.join("#{base_dir}", pattern)]
end
def list_js_files(base_dir)
list_files(base_dir, "**/*.es6")
end
def grep_files(files, regex)
files.select { |file| grep_file(file, regex) }
end
@ -18,21 +14,6 @@ def grep_file(file, regex)
end
RSpec.describe "Coding style" do
describe "Javascript" do
it 'prevents this.get("foo") pattern' do
js_files = list_js_files("app/assets/javascripts")
offenses = grep_files(js_files, /this\.get\("\w+"\)/)
expect(offenses).to be_empty, <<~TEXT
Do not use this.get("foo") accessor for single property, instead
prefer to use this.foo
Offenses:
#{offenses.join("\n")}
TEXT
end
end
describe "Post Migrations" do
def check_offenses(files, method_name, constant_name)
method_name_regex = /#{Regexp.escape(method_name)}/