From 84af84dc52c3cc08e5784aa52430bc81cf36d533 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9gis=20Hanol?= <regis@hanol.fr>
Date: Mon, 6 Feb 2017 17:49:27 +0100
Subject: [PATCH] prevent inactive & staged users from being automatically
 added to a group

---
 app/models/user.rb       |  2 ++
 spec/models/user_spec.rb | 32 +++++++++++++++++++++++---------
 2 files changed, 25 insertions(+), 9 deletions(-)

diff --git a/app/models/user.rb b/app/models/user.rb
index e8078544d63..9e8df36e763 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -935,6 +935,8 @@ class User < ActiveRecord::Base
   def automatic_group_membership
     user = User.find(self.id)
 
+    return unless user && user.active && !user.staged
+
     Group.where(automatic: false)
          .where("LENGTH(COALESCE(automatic_membership_email_domains, '')) > 0")
          .each do |group|
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index 52cf4ea8415..15498c992e5 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -1183,9 +1183,29 @@ describe User do
 
   describe "automatic group membership" do
 
+    let!(:group) {
+      Fabricate(:group,
+        automatic_membership_email_domains: "bar.com|wat.com",
+        grant_trust_level: 1,
+        title: "bars and wats",
+        primary_group: true
+      )
+    }
+
+    it "doesn't automatically add inactive users" do
+      inactive_user = Fabricate(:user, active: false, email: "wat@wat.com")
+      group.reload
+      expect(group.users.include?(inactive_user)).to eq(false)
+    end
+
+    it "doesn't automatically add staged users" do
+      staged_user = Fabricate(:user, active: true, staged: true, email: "wat@wat.com")
+      group.reload
+      expect(group.users.include?(staged_user)).to eq(false)
+    end
+
     it "is automatically added to a group when the email matches" do
-      group = Fabricate(:group, automatic_membership_email_domains: "bar.com|wat.com")
-      user = Fabricate(:user, email: "foo@bar.com")
+      user = Fabricate(:user, active: true, email: "foo@bar.com")
       group.reload
       expect(group.users.include?(user)).to eq(true)
 
@@ -1197,14 +1217,8 @@ describe User do
     end
 
     it "get attributes from the group" do
-      group = Fabricate(:group,
-        automatic_membership_email_domains: "bar.com|wat.com",
-        grant_trust_level: 1,
-        title: "bars and wats",
-        primary_group: true
-      )
-
       user = Fabricate.build(:user,
+        active: true,
         trust_level: 0,
         email: "foo@bar.com",
         password: "strongpassword4Uguys"