Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove skipped form template system spec (#21832) 

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
This commit is contained in:
Keegan George 2023-05-30 11:37:32 -07:00 committed by GitHub
parent 3569a48b2d
commit 856c4ed295
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spec/system/admin_customize_form_templates_spec.rb
View File

@ -3,23 +3,18 @@
describe "Admin Customize Form Templates", type: :system, js: true do describe "Admin Customize Form Templates", type: :system, js: true do
let(:form_template_page) { PageObjects::Pages::FormTemplate.new } let(:form_template_page) { PageObjects::Pages::FormTemplate.new }
let(:ace_editor) { PageObjects::Components::AceEditor.new } let(:ace_editor) { PageObjects::Components::AceEditor.new }
fab!(:admin) { Fabricate(:admin) } fab!(:admin) { Fabricate(:admin) }
fab!(:form_template) { Fabricate(:form_template) } fab!(:form_template) { Fabricate(:form_template) }
fab!(:category) do fab!(:category) { Fabricate(:category) }
Fabricate(:category, name: "Cool Category", slug: "cool-cat", topic_count: 3234)
end
before do before do
skip(<<~TEXT) if ENV["CI"]
The specs here are extremely flaky on CI for some reason.
TEXT
SiteSetting.experimental_form_templates = true SiteSetting.experimental_form_templates = true
sign_in(admin) sign_in(admin)
end end
describe "when visiting the page to customize form templates" do describe "when visiting the page to customize form templates" do
before { category.update(form_template_ids: [form_template.id]) } before { category.update!(form_template_ids: [form_template.id]) }
it "should show the existing form templates in a table" do it "should show the existing form templates in a table" do
visit("/admin/customize/form-templates") visit("/admin/customize/form-templates")

2
spec/system/page_objects/pages/form_template.rb
View File

@ -31,7 +31,7 @@ module PageObjects
# Form Template new/edit form related # Form Template new/edit form related
def type_in_template_name(input) def type_in_template_name(input)
find(".form-templates__form-name-input").send_keys(input) find(".form-templates__form-name-input").fill_in(with: input)
self self
end end