Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: Limit the amount of badges fixed in the consistency check.

This commit is contained in:
Robin Ward 2014-08-08 15:13:11 -04:00
parent 50ac4c6336
commit 859167470e
1 changed files with 23 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
app/models/user_badge.rb
View File

@ -18,14 +18,31 @@ class UserBadge < ActiveRecord::Base
Badge.decrement_counter 'grant_count', self.badge_id Badge.decrement_counter 'grant_count', self.badge_id
end end
# Make sure we don't have duplicate badges. # Make sure we don't have duplicate badges.
def self.ensure_consistency! def self.ensure_consistency!
dup_ids = [] dup_ids = exec_sql("SELECT u1.id
# Single grant badges shouldn't have duplicates at all. FROM user_badges u1, user_badges u2, badges
dup_ids += exec_sql("SELECT u1.id FROM user_badges u1, user_badges u2, badges WHERE u1.badge_id = badges.id AND u1.user_id = u2.user_id AND u1.badge_id = u2.badge_id AND (NOT badges.multiple_grant) AND u1.granted_at > u2.granted_at").to_a WHERE u1.badge_id = badges.id
# Multiple grant badges can have duplicates but not with the same post_ids. AND u1.user_id = u2.user_id
dup_ids += exec_sql("SELECT u1.id FROM user_badges u1, user_badges u2, badges WHERE u1.badge_id = badges.id AND u1.user_id = u2.user_id AND u1.badge_id = u2.badge_id AND badges.multiple_grant AND u1.post_id = u2.post_id AND u1.granted_at > u2.granted_at").to_a AND u1.badge_id = u2.badge_id
dup_ids = dup_ids.map {|x| x["id"].to_i } AND (NOT badges.multiple_grant)
AND u1.granted_at > u2.granted_at
LIMIT 1000").to_a
dup_ids << exec_sql("SELECT u1.id
FROM user_badges u1, user_badges u2, badges
WHERE u1.badge_id = badges.id
AND u1.user_id = u2.user_id
AND u1.badge_id = u2.badge_id
AND badges.multiple_grant
AND u1.post_id = u2.post_id
AND u1.granted_at > u2.granted_at
LIMIT 1000").to_a
dup_ids.flatten!
dup_ids.map! {|row| row['id'].to_i }
dup_ids.uniq!
UserBadge.where(id: dup_ids).destroy_all UserBadge.where(id: dup_ids).destroy_all
end end
end end