From 87667cfe17d7d31660241793cc009fd30994c415 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Tue, 2 Dec 2014 11:46:21 -0500 Subject: [PATCH] FIX: Editing a category definition topic was clearing its permissions --- app/assets/javascripts/discourse/models/site.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/models/site.js b/app/assets/javascripts/discourse/models/site.js index c66481c9910..c8e09a9dce1 100644 --- a/app/assets/javascripts/discourse/models/site.js +++ b/app/assets/javascripts/discourse/models/site.js @@ -66,7 +66,12 @@ Discourse.Site = Discourse.Model.extend({ updateCategory: function(newCategory) { var existingCategory = this.get('categories').findProperty('id', Em.get(newCategory, 'id')); - if (existingCategory) existingCategory.setProperties(newCategory); + if (existingCategory) { + // Don't update null permissions + if (newCategory.permission === null) { delete newCategory.permission; } + + existingCategory.setProperties(newCategory); + } } });