DEV: Update eslint/prettier (#22226)

.github/labeler.yml

@@ -1,2 +1,2 @@
 chat:
-- plugins/chat/**/*
+  - plugins/chat/**/*

.licensee.json

@@ -11,8 +11,9 @@
   "packages": {
     "@fortawesome/fontawesome-free": "*",
     "ember-template-lint-plugin-discourse": "*",
+    "spawn-command": "0.0.2",
     "squoosh": "2.0.0",
     "taffydb": "2.6.2"
   },
   "corrections": true
-}
+}

app/assets/javascripts/discourse/app/components/reviewable-item.hbs

@@ -59,9 +59,7 @@
       </div>
     {{else}}
       {{#component
-        this.reviewableComponent
+        this.reviewableComponent reviewable=this.reviewable tagName=""
-        reviewable=this.reviewable
-        tagName=""
       }}
         <ReviewableScores @reviewable={{this.reviewable}} @tagName="" />
       {{/component}}

app/assets/stylesheets/common/base/modal.scss

@@ -134,7 +134,9 @@
   }
 
   &:not(.history-modal) {
-    .modal-body:not(.reorder-categories):not(.poll-ui-builder):not(.poll-breakdown):not(.sidebar-categories-form-modal):not(.sidebar-tags-form-modal) {
+    .modal-body:not(.reorder-categories):not(.poll-ui-builder):not(
+        .poll-breakdown
+      ):not(.sidebar-categories-form-modal):not(.sidebar-tags-form-modal) {
       max-height: 80vh !important;
       @media screen and (max-height: 500px) {
         max-height: 65vh !important;

app/assets/stylesheets/common/components/sidebar-categories-form.scss

@@ -86,7 +86,9 @@
     padding: 0.5em 0;
   }
 
-  .sidebar-categories-form__category-row[data-category-level="0"]:not(:only-child) {
+  .sidebar-categories-form__category-row[data-category-level="0"]:not(
+      :only-child
+    ) {
     border-bottom: 1px solid var(--primary-low);
   }
 
@@ -94,7 +96,9 @@
     margin-left: 1em;
   }
 
-  .sidebar-categories-form__category-row[data-category-level="1"]:not(:nth-of-type(2)) {
+  .sidebar-categories-form__category-row[data-category-level="1"]:not(
+      :nth-of-type(2)
+    ) {
     border-top: 1px solid var(--primary-low);
   }
 

app/assets/stylesheets/desktop/login.scss

@@ -437,7 +437,9 @@
       width: 100%;
     }
 
-    .modal-body:not(.reorder-categories):not(.poll-ui-builder):not(.poll-breakdown) {
+    .modal-body:not(.reorder-categories):not(.poll-ui-builder):not(
+        .poll-breakdown
+      ) {
       max-height: 90vh !important; // overrides base/modal.scss
     }
     .login-welcome-header,

package.json

@@ -27,9 +27,9 @@
     "chrome-remote-interface": "^0.31.3",
     "ember-template-lint": "4.10.1",
     "eslint": "^8.37.0",
-    "eslint-config-discourse": "^3.4.0",
+    "eslint-config-discourse": "^3.5.0",
-    "eslint-plugin-ember": "10.6.1",
+    "eslint-plugin-ember": "11.8.0",
-    "eslint-plugin-sort-class-members": "1.14.1",
+    "eslint-plugin-sort-class-members": "1.18.0",
     "jsdoc": "^4.0.0",
     "lefthook": "^1.2.0",
     "lint-to-the-future": "^2.0.0",

plugins/chat/assets/javascripts/discourse/components/chat-message-actions-desktop.hbs

@@ -21,8 +21,7 @@
     >
       {{#if this.shouldRenderFavoriteReactions}}
         {{#each
-          this.messageInteractor.emojiReactions
+          this.messageInteractor.emojiReactions key="emoji"
-          key="emoji"
           as |reaction|
         }}
           <ChatMessageReaction

plugins/chat/assets/stylesheets/common/chat-skeleton.scss

@@ -110,7 +110,11 @@ $radius: 3px;
     position: relative;
     overflow: hidden;
 
-    *[class^="chat-skeleton__message-"]:not(.chat-skeleton__message-content):not(.chat-skeleton__message-text):not(.chat-skeleton__message-reactions):after {
+    *[class^="chat-skeleton__message-"]:not(
+        .chat-skeleton__message-content
+      ):not(.chat-skeleton__message-text):not(
+        .chat-skeleton__message-reactions
+      ):after {
       position: absolute;
       top: 0;
       right: 0;